Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: sky/services/keyboard/org/domokit/keyboard/InputConnectionAdaptor.java

Issue 995073002: Make Sky's EditableText mostly work (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: More comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/services/keyboard/org/domokit/keyboard/InputConnectionAdaptor.java
diff --git a/sky/services/keyboard/org/domokit/keyboard/InputConnectionAdaptor.java b/sky/services/keyboard/org/domokit/keyboard/InputConnectionAdaptor.java
index 3f9a6670766603bfd97da659470cdb4490cd1880..d48df3706eaebf4954ca82159b9957b4a12f0c5d 100644
--- a/sky/services/keyboard/org/domokit/keyboard/InputConnectionAdaptor.java
+++ b/sky/services/keyboard/org/domokit/keyboard/InputConnectionAdaptor.java
@@ -7,8 +7,12 @@ package org.domokit.keyboard;
import android.text.InputType;
import android.view.View;
import android.view.inputmethod.BaseInputConnection;
+import android.view.inputmethod.CompletionInfo;
+import android.view.inputmethod.CorrectionInfo;
import android.view.inputmethod.EditorInfo;
+import org.chromium.mojom.keyboard.CompletionData;
+import org.chromium.mojom.keyboard.CorrectionData;
import org.chromium.mojom.keyboard.KeyboardClient;
/**
@@ -27,15 +31,29 @@ public class InputConnectionAdaptor extends BaseInputConnection {
}
@Override
+ public boolean commitCompletion(CompletionInfo completion) {
+ // TODO(abarth): Copy the data from |completion| to CompletionData.
+ mClient.commitCompletion(new CompletionData());
+ return super.commitCompletion(completion);
+ }
+
+ @Override
+ public boolean commitCorrection(CorrectionInfo correction) {
+ // TODO(abarth): Copy the data from |correction| to CompletionData.
+ mClient.commitCorrection(new CorrectionData());
+ return super.commitCorrection(correction);
+ }
+
+ @Override
public boolean commitText(CharSequence text, int newCursorPosition) {
mClient.commitText(text.toString(), newCursorPosition);
return super.commitText(text, newCursorPosition);
}
@Override
- public boolean setComposingText(CharSequence text, int newCursorPosition) {
- mClient.setComposingText(text.toString(), newCursorPosition);
- return super.setComposingText(text, newCursorPosition);
+ public boolean deleteSurroundingText(int beforeLength, int afterLength) {
+ mClient.deleteSurroundingText(beforeLength, afterLength);
+ return super.deleteSurroundingText(beforeLength, afterLength);
}
@Override
@@ -43,4 +61,16 @@ public class InputConnectionAdaptor extends BaseInputConnection {
mClient.setComposingRegion(start, end);
return super.setComposingRegion(start, end);
}
+
+ @Override
+ public boolean setComposingText(CharSequence text, int newCursorPosition) {
+ mClient.setComposingText(text.toString(), newCursorPosition);
+ return super.setComposingText(text, newCursorPosition);
+ }
+
+ @Override
+ public boolean setSelection(int start, int end) {
+ mClient.setSelection(start, end);
+ return super.setSelection(start, end);
+ }
}
« sky/examples/editor/editable_string.dart ('K') | « sky/services/keyboard/keyboard.mojom ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698