Add Clone and disallow copy construction for NavigationEntryImpl.

Add Clone and disallow copy construction for NavigationEntryImpl.

This will matter as NavigationEntries start to share FrameNavigationEntries
for --site-per-process.  At that point, cloning a NavigationEntry will need
to take into account whether the copy will live in the same tab or not, as
well as making a deep copy of the FrameNavigationEntry tree.

BUG=236848
TEST=No behavior change yet.

Committed: https://crrev.com/ef4a0cb79857ed187311cd72ef475899c72e9f15
Cr-Commit-Position: refs/heads/master@{#320338}

[Charlie Reis, 2015-03-12 16:51:19]

creis@chromium.org changed reviewers:
+ avi@chromium.org

[Charlie Reis, 2015-03-12 16:51:20]

Avi: Here's the next step in supporting FrameNavigationEntry.  I've confirmed
that we want to be able to share them between NavigationEntries, so we'll need a
way to clone NavigationEntries rather than using the default copy constructor.

https://codereview.chromium.org/994803004/diff/60001/content/public/browser/n...
File content/public/browser/navigation_entry.h (left):

https://codereview.chromium.org/994803004/diff/60001/content/public/browser/n...
content/public/browser/navigation_entry.h:35: CONTENT_EXPORT static
NavigationEntry* Create(const NavigationEntry& copy);
Note: This was dead code.

[Avi (use Gerrit), 2015-03-12 16:59:19]

LGTM

https://codereview.chromium.org/994803004/diff/60001/content/browser/frame_ho...
File content/browser/frame_host/navigation_entry_impl.h (right):

https://codereview.chromium.org/994803004/diff/60001/content/browser/frame_ho...
content/browser/frame_host/navigation_entry_impl.h:99: // tab) and one that
draws them from a different pool (for use in a new tab).
Does this version of Clone have one of those behaviors? If you can decide what
those two Clones will be called
(CloneForSameController/CloneForDifferentController or maybe
CloneForController(NavController*) perhaps you might want to name it like that
now.

[Charlie Reis, 2015-03-12 17:07:43]

Thanks!

https://codereview.chromium.org/994803004/diff/60001/content/browser/frame_ho...
File content/browser/frame_host/navigation_entry_impl.h (right):

https://codereview.chromium.org/994803004/diff/60001/content/browser/frame_ho...
content/browser/frame_host/navigation_entry_impl.h:99: // tab) and one that
draws them from a different pool (for use in a new tab).
On 2015/03/12 16:59:19, Avi wrote:
> Does this version of Clone have one of those behaviors? If you can decide what
> those two Clones will be called
> (CloneForSameController/CloneForDifferentController or maybe
> CloneForController(NavController*) perhaps you might want to name it like that
> now.

Yeah, I hadn't thought closely about whether to have two methods or give a
parameter, since I'm not sure what we'll need to pass in yet.  (So far
NavigationEntry doesn't depend on NavigationController at all, so it might be
nice to pass in some kind of mutable set of FrameNavigationEntries.)

At the moment, there's no difference between the behaviors since we don't have
shared entries.  Let's wait on the new name until there's a behavior difference.

[Charlie Reis, 2015-03-12 17:27:28]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2015-03-12 17:28:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/994803004/60001

[Charlie Reis, 2015-03-12 17:56:33]

The CQ bit was unchecked by creis@chromium.org

[Charlie Reis, 2015-03-12 17:59:46]

Note: The ASAN bot caught that I was leaking the cloned entry in the unit test. 
Fixed in patch 5.  I'll CQ it again.

[Charlie Reis, 2015-03-12 17:59:52]

The CQ bit was checked by creis@chromium.org

[Charlie Reis, 2015-03-12 17:59:52]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/994803004/#ps80001 (title:
"Fix leak in test.")

[commit-bot: I haz the power, 2015-03-12 18:00:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/994803004/80001

[commit-bot: I haz the power, 2015-03-12 19:14:45]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-12 19:15:30]

Patchset 5 (id:??) landed as
https://crrev.com/ef4a0cb79857ed187311cd72ef475899c72e9f15
Cr-Commit-Position: refs/heads/master@{#320338}