Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Side by Side Diff: content/public/browser/navigation_entry.h

Issue 994803004: Add Clone and disallow copy construction for NavigationEntryImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_
6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_ 6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/ref_counted_memory.h" 10 #include "base/memory/ref_counted_memory.h"
(...skipping 14 matching lines...) Expand all
25 25
26 // A NavigationEntry is a data structure that captures all the information 26 // A NavigationEntry is a data structure that captures all the information
27 // required to recreate a browsing state. This includes some opaque binary 27 // required to recreate a browsing state. This includes some opaque binary
28 // state as provided by the WebContents as well as some clear text title and 28 // state as provided by the WebContents as well as some clear text title and
29 // URL which is used for our user interface. 29 // URL which is used for our user interface.
30 class NavigationEntry { 30 class NavigationEntry {
31 public: 31 public:
32 virtual ~NavigationEntry() {} 32 virtual ~NavigationEntry() {}
33 33
34 CONTENT_EXPORT static NavigationEntry* Create(); 34 CONTENT_EXPORT static NavigationEntry* Create();
35 CONTENT_EXPORT static NavigationEntry* Create(const NavigationEntry& copy);
Charlie Reis 2015/03/12 16:51:20 Note: This was dead code.
36 35
37 // Page-related stuff -------------------------------------------------------- 36 // Page-related stuff --------------------------------------------------------
38 37
39 // A unique ID is preserved across commits and redirects, which means that 38 // A unique ID is preserved across commits and redirects, which means that
40 // sometimes a NavigationEntry's unique ID needs to be set (e.g. when 39 // sometimes a NavigationEntry's unique ID needs to be set (e.g. when
41 // creating a committed entry to correspond to a to-be-deleted pending entry, 40 // creating a committed entry to correspond to a to-be-deleted pending entry,
42 // the pending entry's ID must be copied). 41 // the pending entry's ID must be copied).
43 virtual int GetUniqueID() const = 0; 42 virtual int GetUniqueID() const = 0;
44 43
45 // The page type tells us if this entry is for an interstitial or error page. 44 // The page type tells us if this entry is for an interstitial or error page.
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 virtual void SetRedirectChain(const std::vector<GURL>& redirects) = 0; 214 virtual void SetRedirectChain(const std::vector<GURL>& redirects) = 0;
216 virtual const std::vector<GURL>& GetRedirectChain() const = 0; 215 virtual const std::vector<GURL>& GetRedirectChain() const = 0;
217 216
218 // True if this entry is restored and hasn't been loaded. 217 // True if this entry is restored and hasn't been loaded.
219 virtual bool IsRestored() const = 0; 218 virtual bool IsRestored() const = 0;
220 }; 219 };
221 220
222 } // namespace content 221 } // namespace content
223 222
224 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_ 223 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698