Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 994753002: Revert of [Andorid] ClipDrawable progress bar experiment. (Closed)

Created:
5 years, 9 months ago by Kibeom Kim (inactive)
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Andorid] ClipDrawable progress bar experiment. (patchset #2 id:20001 of https://codereview.chromium.org/960733002/) Reason for revert: Although ClipDrawableProgressBar showed some perf improvement on blink_perf.svg, it didn't show any meaningful difference on page_cycler.top_10_mobile test. Original issue's description: > [Andorid] ClipDrawable progress bar experiment. > > Recently it was discovered that ClipDrawable is much faster than our > default ToolbarProgressBar on content shell. > > So we plan to experiment with ClipDrawable based progress bar > implementation. > > BUG=455891 > > Committed: https://crrev.com/b13144e2f2b4ac80f81cee8ce4d4c7f4831b625e > Cr-Commit-Position: refs/heads/master@{#318292} TBR=dtrainor@chromium.org,jaekyun@chromium.org NOPRESUBMIT=false NOTREECHECKS=false NOTRY=false BUG=455891 Committed: https://crrev.com/2bdff99f3766d74ee9223125270599b5fe7000ed Cr-Commit-Position: refs/heads/master@{#319777}

Patch Set 1 #

Patch Set 2 : Add progress_bar.xml back which was removed in https://codereview.chromium.org/971223004 #

Messages

Total messages: 13 (6 generated)
Kibeom Kim (inactive)
Created Revert of [Andorid] ClipDrawable progress bar experiment.
5 years, 9 months ago (2015-03-09 20:50:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/994753002/1
5 years, 9 months ago (2015-03-09 21:01:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_rel/builds/22925)
5 years, 9 months ago (2015-03-09 22:13:13 UTC) #7
David Trainor- moved to gerrit
lgtm
5 years, 9 months ago (2015-03-09 22:44:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/994753002/180001
5 years, 9 months ago (2015-03-09 23:01:33 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:180001)
5 years, 9 months ago (2015-03-09 23:54:58 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 23:56:11 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2bdff99f3766d74ee9223125270599b5fe7000ed
Cr-Commit-Position: refs/heads/master@{#319777}

Powered by Google App Engine
This is Rietveld 408576698