Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 960733002: [Andorid] ClipDrawable progress bar experiment. (Closed)

Created:
5 years, 10 months ago by Kibeom Kim (inactive)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Andorid] ClipDrawable progress bar experiment. Recently it was discovered that ClipDrawable is much faster than our default ToolbarProgressBar on content shell. So we plan to experiment with ClipDrawable based progress bar implementation. BUG=455891 Committed: https://crrev.com/b13144e2f2b4ac80f81cee8ce4d4c7f4831b625e Cr-Commit-Position: refs/heads/master@{#318292}

Patch Set 1 #

Patch Set 2 : updated test #

Messages

Total messages: 11 (3 generated)
Kibeom Kim (inactive)
ptal. Initially I made ClipDrawableProgressBar almost the same as ToolbarProgressBar, but decided to check-in the ...
5 years, 10 months ago (2015-02-26 02:48:32 UTC) #2
Jaekyun Seok (inactive)
On 2015/02/26 02:48:32, Kibeom Kim wrote: > ptal. > > Initially I made ClipDrawableProgressBar almost ...
5 years, 10 months ago (2015-02-26 04:32:50 UTC) #3
David Trainor- moved to gerrit
lgtm once tests are fixed.
5 years, 10 months ago (2015-02-26 06:08:05 UTC) #4
Kibeom Kim (inactive)
Updated the test to ClipDrawableProgressBarTest. I'll add ToolbarProgressBarTest back in downstream after this CL lands. ...
5 years, 10 months ago (2015-02-26 19:19:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960733002/20001
5 years, 10 months ago (2015-02-26 19:25:09 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-26 20:05:40 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b13144e2f2b4ac80f81cee8ce4d4c7f4831b625e Cr-Commit-Position: refs/heads/master@{#318292}
5 years, 10 months ago (2015-02-26 20:07:35 UTC) #10
Kibeom Kim (inactive)
5 years, 9 months ago (2015-03-09 20:50:57 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/994753002/ by kkimlabs@chromium.org.

The reason for reverting is: Although ClipDrawableProgressBar showed some perf
improvement on blink_perf.svg, it didn't show any meaningful difference on
page_cycler.top_10_mobile test..

Powered by Google App Engine
This is Rietveld 408576698