Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 994533004: Contribution of PowerPC port (continuation of 422063005) - uplevel (Closed)

Created:
5 years, 9 months ago by michael_dawson
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne, danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Contribution of PowerPC port (continuation of 422063005) - uplevel Contribution of PowerPC port (continuation of 422063005, 817143002,866843003, and 901083004). This patch updates the ppc directories to make them current with changes in common code as of today. We had to exclude the test test-serialize/SerializeInternalReference until we agree on the right way to add those changes for PPC as outlined in the description in the google doc provided earlier. We also had to exclude a couple of other tests due to new failures seen since the last uplevel. We excluded as opposed to waiting until we could investigate to maximize the chance of getting PPC compiling in the google repos before new breaking changes are made. I'll note that before applying any of our changes the mozilla part of quickcheck was already broken when using the lastest repo content so I had to run without that modified: src/compiler/ppc/code-generator-ppc.cc modified: src/compiler/ppc/instruction-codes-ppc.h modified: src/compiler/ppc/instruction-selector-ppc.cc modified: src/ic/ppc/handler-compiler-ppc.cc modified: src/ic/ppc/ic-compiler-ppc.cc modified: src/ppc/assembler-ppc-inl.h modified: src/ppc/assembler-ppc.cc modified: src/ppc/assembler-ppc.h modified: src/ppc/builtins-ppc.cc modified: src/ppc/code-stubs-ppc.cc modified: src/ppc/codegen-ppc.cc modified: src/ppc/full-codegen-ppc.cc modified: src/ppc/lithium-codegen-ppc.cc modified: src/ppc/macro-assembler-ppc.cc modified: src/ppc/macro-assembler-ppc.h modified: test/cctest/cctest.status R=danno@chromium.org, svenpanne@chromium.org BUG= Committed: https://crrev.com/45e4a7891189d9002e6220991adfe27423c27287 Cr-Commit-Position: refs/heads/master@{#27125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+549 lines, -408 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-codes-ppc.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 4 chunks +64 lines, -19 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 3 chunks +15 lines, -21 lines 0 comments Download
M src/ic/ppc/ic-compiler-ppc.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/ppc/assembler-ppc.h View 7 chunks +26 lines, -21 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 14 chunks +109 lines, -75 lines 0 comments Download
M src/ppc/assembler-ppc-inl.h View 2 chunks +35 lines, -16 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/ppc/code-stubs-ppc.cc View 12 chunks +115 lines, -54 lines 0 comments Download
M src/ppc/codegen-ppc.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 8 chunks +58 lines, -25 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 chunk +24 lines, -36 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 4 chunks +5 lines, -13 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 4 chunks +49 lines, -121 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +5 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
michael_dawson
Changes to bring us up to current with latest changes in the common code.
5 years, 9 months ago (2015-03-10 22:32:45 UTC) #1
Sven Panne
lgtm
5 years, 9 months ago (2015-03-11 08:11:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/994533004/1
5 years, 9 months ago (2015-03-11 08:12:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-11 08:49:33 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 08:49:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45e4a7891189d9002e6220991adfe27423c27287
Cr-Commit-Position: refs/heads/master@{#27125}

Powered by Google App Engine
This is Rietveld 408576698