Issue 994533003: Revert of Add policy_templates target for GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 994533003: Revert of Add policy_templates target for GN. (Closed)

Created:
5 years, 9 months ago by Marc Treib

Modified:
5 years, 9 months ago

Reviewers:
Bernhard Bauer, knn, pneubeck (no reviews)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Add policy_templates target for GN. (patchset #3 id:40001 of https://codereview.chromium.org/957283003/) Reason for revert: Seems to have broken (at least) the Mac GN build: http://build.chromium.org/p/chromium.mac/builders/Mac%20GN http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20(dbg) Original issue's description: > Add policy_templates target for GN. > > BUG=462362 > > Committed: https://crrev.com/f24e2a468f0fffe65f626ba5d7c4c0089a78a65e > Cr-Commit-Position: refs/heads/master@{#319616} TBR=pneubeck@chromium.org,bauerb@chromium.org,knn@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462362 Committed: https://crrev.com/2e35995d21e6c2b543cc97d73c8a505f54dc3d5a Cr-Commit-Position: refs/heads/master@{#319620}

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -313 lines)			Patch
	M	components/policy/BUILD.gn	View		2 chunks	+1 line, -21 lines	0 comments	Download
	D	components/policy/resources/policy_templates.gni	View		1 chunk	+0 lines, -292 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/994533003/1

5 years, 9 months ago (2015-03-09 13:36:16 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-09 13:37:38 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2e35995d21e6c2b543cc97d73c8a505f54dc3d5a
Cr-Commit-Position: refs/heads/master@{#319620}