Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 957283003: Add policy_templates target for GN. (Closed)

Created:
5 years, 10 months ago by knn
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add policy_templates target for GN. BUG=462362

Patch Set 1 #

Total comments: 2

Patch Set 2 : Scope outputs by {policy_templates} as Gn variables are global. #

Total comments: 2

Patch Set 3 : s/templates_dir/policy_templates_base_dir #

Patch Set 4 : Mac fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -1 line) Patch
M components/policy/BUILD.gn View 1 2 3 2 chunks +29 lines, -1 line 0 comments Download
A components/policy/resources/policy_templates.gni View 1 2 1 chunk +292 lines, -0 lines 0 comments Download

Messages

Total messages: 36 (14 generated)
knn
Please Review.
5 years, 9 months ago (2015-02-27 10:45:45 UTC) #2
knn
On 2015/02/27 10:45:45, knn wrote: > Please Review. Hi Philipp, Can you review my change ...
5 years, 9 months ago (2015-03-02 13:48:43 UTC) #3
pneubeck (no reviews)
https://codereview.chromium.org/957283003/diff/1/components/policy/BUILD.gn File components/policy/BUILD.gn (right): https://codereview.chromium.org/957283003/diff/1/components/policy/BUILD.gn#newcode124 components/policy/BUILD.gn:124: output_dir = "$root_gen_dir/chrome" if you set this, shouldn't all ...
5 years, 9 months ago (2015-03-03 17:32:03 UTC) #4
knn
TLDR: Should I use relative paths in policy_templates.gni? https://codereview.chromium.org/957283003/diff/1/components/policy/BUILD.gn File components/policy/BUILD.gn (right): https://codereview.chromium.org/957283003/diff/1/components/policy/BUILD.gn#newcode124 components/policy/BUILD.gn:124: output_dir ...
5 years, 9 months ago (2015-03-03 19:22:41 UTC) #5
pneubeck (no reviews)
thanks for the explanation. As discussed, I'm fine with both relative and absolute paths for ...
5 years, 9 months ago (2015-03-03 19:33:20 UTC) #6
knn
On 2015/03/03 19:33:20, pneubeck wrote: > thanks for the explanation. > As discussed, I'm fine ...
5 years, 9 months ago (2015-03-06 21:50:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957283003/20001
5 years, 9 months ago (2015-03-06 22:49:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 00:52:29 UTC) #12
pneubeck (no reviews)
https://codereview.chromium.org/957283003/diff/20001/components/policy/resources/policy_templates.gni File components/policy/resources/policy_templates.gni (right): https://codereview.chromium.org/957283003/diff/20001/components/policy/resources/policy_templates.gni#newcode8 components/policy/resources/policy_templates.gni:8: templates_dir = "$root_gen_dir/chrome/app/policy" AFAIU, this variable is also exported ...
5 years, 9 months ago (2015-03-07 02:05:45 UTC) #13
knn
Done. https://codereview.chromium.org/957283003/diff/20001/components/policy/resources/policy_templates.gni File components/policy/resources/policy_templates.gni (right): https://codereview.chromium.org/957283003/diff/20001/components/policy/resources/policy_templates.gni#newcode8 components/policy/resources/policy_templates.gni:8: templates_dir = "$root_gen_dir/chrome/app/policy" On 2015/03/07 02:05:45, pneubeck wrote: ...
5 years, 9 months ago (2015-03-09 10:23:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957283003/40001
5 years, 9 months ago (2015-03-09 10:23:32 UTC) #17
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 10:45:56 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957283003/40001
5 years, 9 months ago (2015-03-09 11:59:17 UTC) #22
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 11:59:59 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957283003/40001
5 years, 9 months ago (2015-03-09 13:11:36 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-09 13:12:13 UTC) #28
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/f24e2a468f0fffe65f626ba5d7c4c0089a78a65e Cr-Commit-Position: refs/heads/master@{#319616}
5 years, 9 months ago (2015-03-09 13:13:04 UTC) #29
Marc Treib
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/994533003/ by treib@chromium.org. ...
5 years, 9 months ago (2015-03-09 13:35:57 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957283003/60001
5 years, 9 months ago (2015-03-09 22:41:56 UTC) #33
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-09 23:12:29 UTC) #34
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/982eb90bf74535cbe5e21c4eacb759c42ff424d4 Cr-Commit-Position: refs/heads/master@{#319759}
5 years, 9 months ago (2015-03-09 23:13:24 UTC) #35
dgrogan
5 years, 9 months ago (2015-03-09 23:46:47 UTC) #36
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/992863002/ by dgrogan@chromium.org.

The reason for reverting is: Possibly broke some GN builds (reverted with
https://codereview.chromium.org/865573002), e.g.:

http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/24483/s...
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

ninja: Entering directory
`/mnt/data/b/build/slave/Linux_GN/build/src/out/Release'
ninja:error: expected depfile 'gen/chrome/policy_templates.d' to mention
'gen/chrome/app/policy/common/html/am/chrome_policy_list.html', got
'gen/chrome/app/policy/linux/examples/chrome.json'
.

Powered by Google App Engine
This is Rietveld 408576698