content/browser/accessibility/browser_accessibility_cocoa.mm - Issue 994373003: Calls BrowserAccessibility::IsCellOrTableHeaderRole() with a correct instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 994373003: Calls BrowserAccessibility::IsCellOrTableHeaderRole() with a correct instance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/accessibility/browser_accessibility.cc ('K') | « content/browser/accessibility/browser_accessibility.cc ('k') | content/browser/accessibility/browser_accessibility_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_cocoa.mm

diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm

index 88487ca1d1e199cc1ee611bdedd1394816e3c337..b9e32d1ebb8384d4fef4b05380fbe8064159455f 100644

--- a/content/browser/accessibility/browser_accessibility_cocoa.mm

+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm

@@ -237,7 +237,7 @@ NSDictionary* attributeToMethodNameMap = nil;

}

- (NSValue*)columnIndexRange {

- if (!browserAccessibility_->IsCellOrTableHeaderRole())

+ if (!browserAccessibility_->IsCellOrTableHeaderRole([self internalRole]))

return nil;

int column = -1;

@@ -710,7 +710,7 @@ NSDictionary* attributeToMethodNameMap = nil;

}

- (NSValue*)rowIndexRange {

- if (!browserAccessibility_->IsCellOrTableHeaderRole())

+ if (!browserAccessibility_->IsCellOrTableHeaderRole([self internalRole]))

return nil;

int row = -1;

@@ -1146,7 +1146,7 @@ NSDictionary* attributeToMethodNameMap = nil;

j < child->PlatformChildCount();

++j) {

BrowserAccessibility* cell = child->PlatformGetChild(j);

- if (!browserAccessibility_->IsCellOrTableHeaderRole())

+ if (!browserAccessibility_->IsCellOrTableHeaderRole(cell->GetRole()))

dmazzoni 2015/03/11 16:31:41 I think this line was the one that had the bug, ri

je_julie(Not used) 2015/03/11 23:21:16 You're right. I didn't see it correctly. On 2015/

continue;

int colIndex;

if (!cell->GetIntAttribute(