content/browser/accessibility/browser_accessibility.cc - Issue 994373003: Calls BrowserAccessibility::IsCellOrTableHeaderRole() with a correct instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility.cc

Issue 994373003: Calls BrowserAccessibility::IsCellOrTableHeaderRole() with a correct instance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility.h ('k') | content/browser/accessibility/browser_accessibility_cocoa.mm » ('j') | content/browser/accessibility/browser_accessibility_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility.cc

diff --git a/content/browser/accessibility/browser_accessibility.cc b/content/browser/accessibility/browser_accessibility.cc

index 7a8c56020e5dcd761f5b3378e801c046a8a272a0..ab5e9334525343737e5903ff44650a25a68f9962 100644

--- a/content/browser/accessibility/browser_accessibility.cc

+++ b/content/browser/accessibility/browser_accessibility.cc

@@ -684,10 +684,10 @@ bool BrowserAccessibility::HasState(ui::AXState state_enum) const {

return (GetState() >> state_enum) & 1;

}

-bool BrowserAccessibility::IsCellOrTableHeaderRole() const {

- return (GetRole() == ui::AX_ROLE_CELL ||

- GetRole() == ui::AX_ROLE_COLUMN_HEADER ||

- GetRole() == ui::AX_ROLE_ROW_HEADER);

+bool BrowserAccessibility::IsCellOrTableHeaderRole(int32 role) const {

dmazzoni 2015/03/11 16:31:41 I don't think it's necessary to add this argument

+ return (role == ui::AX_ROLE_CELL ||

+ role == ui::AX_ROLE_COLUMN_HEADER ||

+ role == ui::AX_ROLE_ROW_HEADER);

}

bool BrowserAccessibility::IsEditableText() const {