Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 994303003: Adjust atlas sizes to fix Mali400 precision issues (Closed)

Created:
5 years, 9 months ago by jvanverth1
Modified:
5 years, 9 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Adjust atlas sizes to fix Mali400 precision issues The previous change to atlas sizes introduced an issue where texture coordinates for glyphs stored on the right side of the atlas were being computed in an imprecise manner on Mali400 chips. The only reasonable fix appears to be to use power-of-two texture sizes. This widens the glyph atlas to the next power of 2 (or 2048) for A8 glyphs only, and widens each GrPlot by 2x as well. By doing this, we can fit 3-4 large distance field glyphs into a single GrPlot, which gives us 100-128 total large glyphs at one time. The 565 and 8888 glyph atlases are kept in their original size to preserve space. BUG=skia:3523 Committed: https://skia.googlesource.com/skia/+/cb251f1d0a8aa7f3e6f685b45046173fc05f4b92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -33 lines) Patch
M src/gpu/GrDistanceFieldTextContext.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M src/gpu/GrFontAtlasSizes.h View 1 chunk +14 lines, -16 lines 0 comments Download
M src/gpu/GrFontCache.cpp View 2 chunks +20 lines, -8 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 chunk +9 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jvanverth1
5 years, 9 months ago (2015-03-11 16:46:46 UTC) #2
joshualitt
On 2015/03/11 16:46:46, jvanverth1 wrote: lgtm
5 years, 9 months ago (2015-03-11 16:53:19 UTC) #3
joshualitt
On 2015/03/11 16:53:19, joshualitt wrote: > On 2015/03/11 16:46:46, jvanverth1 wrote: > > lgtm (I ...
5 years, 9 months ago (2015-03-11 16:53:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/994303003/1
5 years, 9 months ago (2015-03-11 17:42:45 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 18:18:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cb251f1d0a8aa7f3e6f685b45046173fc05f4b92

Powered by Google App Engine
This is Rietveld 408576698