Compile quic_server on MacOS

Compile quic_server on MacOS

BUG=461857
Committed: https://crrev.com/e0f2b8f00e9a70285f25c42d4ab9612b0e0013ca
Cr-Commit-Position: refs/heads/master@{#320809}

[dougk, 2015-03-10 23:02:49]

dougk@chromium.org changed reviewers:
+ alyssar@google.com, rch@chromium.org

[dougk, 2015-03-10 23:02:50]

Well guess what! 'quic_server' doesn't need 'quic_server.cc' Who'd have thought?
Anyway, producing the executable is a simple change to the build files, but
compiling 'quic_server' and 'quic_client' is still not working.

Regarding the different diffs in GN and GYP: quic_tools is a static library in
gyp, but the symbolic name of a set of files in gn.

[Ryan Hamilton, 2015-03-12 03:34:38]

lgtm

https://codereview.chromium.org/994193002/diff/1/net/tools/quic/quic_client.cc
File net/tools/quic/quic_client.cc (right):

https://codereview.chromium.org/994193002/diff/1/net/tools/quic/quic_client.c...
net/tools/quic/quic_client.cc:126: return false;  // failure already logged
nit: We use {}s in one-line ifs for code that's shared.

https://codereview.chromium.org/994193002/diff/1/net/tools/quic/quic_socket_u...
File net/tools/quic/quic_socket_utils.cc (right):

https://codereview.chromium.org/994193002/diff/1/net/tools/quic/quic_socket_u...
net/tools/quic/quic_socket_utils.cc:14: #define __APPLE_USE_RFC_3542
Should this be wrapped in an #if apple_or_darwin_or whatever?
Should we also undef it after we use it?

[dougk, 2015-03-12 12:39:10]

https://codereview.chromium.org/994193002/diff/1/net/tools/quic/quic_client.cc
File net/tools/quic/quic_client.cc (right):

https://codereview.chromium.org/994193002/diff/1/net/tools/quic/quic_client.c...
net/tools/quic/quic_client.cc:126: return false;  // failure already logged
On 2015/03/12 03:34:38, Ryan Hamilton wrote:
> nit: We use {}s in one-line ifs for code that's shared.

Done.

https://codereview.chromium.org/994193002/diff/1/net/tools/quic/quic_socket_u...
File net/tools/quic/quic_socket_utils.cc (right):

https://codereview.chromium.org/994193002/diff/1/net/tools/quic/quic_socket_u...
net/tools/quic/quic_socket_utils.cc:14: #define __APPLE_USE_RFC_3542
Personally I find it less ugly not to add preamble and postamble noise on top of
the required noise.
- It seems to be a deliberately obscure (system-internal) name chosen not to
conflict with anything.
- It's done being used after <netinet/in> is included, but putting an #undef
there is another wart. 
Makes no difference to me though.
Are these convincing enough arguments to leave it alone?

[Ryan Hamilton, 2015-03-12 17:55:41]

https://codereview.chromium.org/994193002/diff/1/net/tools/quic/quic_socket_u...
File net/tools/quic/quic_socket_utils.cc (right):

https://codereview.chromium.org/994193002/diff/1/net/tools/quic/quic_socket_u...
net/tools/quic/quic_socket_utils.cc:14: #define __APPLE_USE_RFC_3542
On 2015/03/12 12:39:10, dougk wrote:
> Personally I find it less ugly not to add preamble and postamble noise on top
of
> the required noise.
> - It seems to be a deliberately obscure (system-internal) name chosen not to
> conflict with anything.
> - It's done being used after <netinet/in> is included, but putting an #undef
> there is another wart. 
> Makes no difference to me though.
> Are these convincing enough arguments to leave it alone?

I'm happy with adding a #undef but leaving off an #if is_whatever

[dougk, 2015-03-16 21:08:48]

The CQ bit was checked by dougk@chromium.org

[dougk, 2015-03-16 21:08:49]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/994193002/#ps40001 (title:
"undefine __APPLE_USE_RFC_n after use")

[commit-bot: I haz the power, 2015-03-16 21:09:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/994193002/40001

[commit-bot: I haz the power, 2015-03-16 22:40:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-16 22:41:17]

Patchset 3 (id:??) landed as
https://crrev.com/e0f2b8f00e9a70285f25c42d4ab9612b0e0013ca
Cr-Commit-Position: refs/heads/master@{#320809}