Compile quic_server on MacOS

net/tools/quic/quic_socket_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/tools/quic/quic_socket_utils.h"
 
 #include <errno.h>
+// Apple's "in6.h" header file says:
+//  *  RFC 3542 define[s] the following socket options in a manner incompatible
+//  *  with RFC 2292:
+//  *    IPV6_PKTINFO
+// and in order to get IPV6_PKTINFO defined at all,
+// you must pick a mode, as follows:
+#define __APPLE_USE_RFC_3542

[Ryan Hamilton, 2015/03/12 03:34:38]

Should this be wrapped in an #if apple_or_darwin_or whatever?
Should we also undef it after we use it?

[dougk, 2015/03/12 12:39:10]

Personally I find it less ugly not to add preamble and postamble noise on top of
the required noise.
- It seems to be a deliberately obscure (system-internal) name chosen not to
conflict with anything.
- It's done being used after <netinet/in> is included, but putting an #undef
there is another wart. 
Makes no difference to me though.
Are these convincing enough arguments to leave it alone?

[Ryan Hamilton, 2015/03/12 17:55:41]

I'm happy with adding a #undef but leaving off an #if is_whatever

 #include <netinet/in.h>
 #include <sys/socket.h>
 #include <sys/uio.h>
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "net/quic/quic_protocol.h"
 
 #ifndef SO_RXQ_OVFL
@@ skipping 221 matching lines @@
   int rc = sendmsg(fd, &hdr, 0);
   if (rc >= 0) {
     return WriteResult(WRITE_STATUS_OK, rc);
   }
   return WriteResult((errno == EAGAIN || errno == EWOULDBLOCK) ?
       WRITE_STATUS_BLOCKED : WRITE_STATUS_ERROR, errno);
 }
 
 }  // namespace tools
 }  // namespace net