Source/bindings/modules/v8/custom/custom.gni - Issue 993893002: Add the data attribute to the Notification object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/modules/v8/custom/custom.gni

Issue 993893002: Add the data attribute to the Notification object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: [WIP] modified wrong comment. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/modules/v8/custom/custom.gni

diff --git a/Source/bindings/modules/v8/custom/custom.gni b/Source/bindings/modules/v8/custom/custom.gni

index b22f9aeb381c5029bc75f2659d3a8dcd75731bae..9967c8ef98a2f508f6c9574f1b0cc0691dafe45a 100644

--- a/Source/bindings/modules/v8/custom/custom.gni

+++ b/Source/bindings/modules/v8/custom/custom.gni

@@ -11,6 +11,7 @@ bindings_modules_v8_custom_files = get_path_info(

"V8CustomSQLStatementErrorCallback.cpp",

"V8DeviceMotionEventCustom.cpp",

"V8DeviceOrientationEventCustom.cpp",

+ "V8NotificationCustom.cpp",

"V8ServiceWorkerCustom.cpp",

"abspath")