Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Unified Diff: Source/modules/notifications/Notification.h

Issue 993893002: Add the data attribute to the Notification object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: [WIP] modified wrong comment. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/notifications/Notification.h
diff --git a/Source/modules/notifications/Notification.h b/Source/modules/notifications/Notification.h
index 4074afbeba9fe6eeb0739c61ab33505b0d1f502c..8bcb6e318ca705d85cb01a5700a61e6e33ad278b 100644
--- a/Source/modules/notifications/Notification.h
+++ b/Source/modules/notifications/Notification.h
@@ -31,6 +31,7 @@
#ifndef Notification_h
#define Notification_h
+#include "bindings/core/v8/SerializedScriptValue.h"
Peter Beverloo 2015/03/10 23:34:26 nit: I think we can forward declare this? All cons
Sanghyun Park 2015/03/11 10:59:52 This header is required, becuase build break is oc
#include "core/dom/ActiveDOMObject.h"
#include "modules/EventTargetModules.h"
#include "platform/AsyncMethodRunner.h"
@@ -47,6 +48,7 @@ namespace blink {
class ExecutionContext;
class NotificationOptions;
class NotificationPermissionCallback;
+class ScriptValue;
struct WebNotificationData;
class Notification final : public RefCountedGarbageCollectedEventTargetWithInlineData<Notification>, public ActiveDOMObject, public WebNotificationDelegate {
@@ -76,6 +78,7 @@ public:
void dispatchErrorEvent() override;
void dispatchCloseEvent() override;
+ SerializedScriptValue* data() const { return m_data.get(); }
String title() const { return m_title; }
String dir() const { return m_dir; }
String lang() const { return m_lang; }
@@ -115,6 +118,7 @@ private:
// instance until the operation completes.
void show();
+ void setData(PassRefPtr<SerializedScriptValue> data) { m_data = data; }
void setDir(const String& dir) { m_dir = dir; }
void setLang(const String& lang) { m_lang = lang; }
void setBody(const String& body) { m_body = body; }
@@ -125,6 +129,7 @@ private:
void setPersistentId(const String& persistentId) { m_persistentId = persistentId; }
private:
+ RefPtr<SerializedScriptValue> m_data;
String m_title;
String m_dir;
String m_lang;

Powered by Google App Engine
This is Rietveld 408576698