Add the data attribute to the Notification object

Source/modules/notifications/Notification.h

Index: Source/modules/notifications/Notification.h
diff --git a/Source/modules/notifications/Notification.h b/Source/modules/notifications/Notification.h
index 4074afbeba9fe6eeb0739c61ab33505b0d1f502c..9916e452ddd26d11d9fd6d7c715f11a6660065cf 100644
--- a/Source/modules/notifications/Notification.h
+++ b/Source/modules/notifications/Notification.h
@@ -31,6 +31,7 @@
 #ifndef Notification_h
 #define Notification_h
 
+#include "bindings/core/v8/SerializedScriptValue.h"

[vivekg, 2015/03/13 04:21:49]

nit: SerializedScriptValue can be forward declared.

[Sanghyun Park, 2015/03/13 05:03:08]

This header is required, becuase build break is occurred in "void
setSerializedData(PassRefPtr<SerializedScriptValue> data) {
m_dataAsSerializedScriptValue = data; }"
Because 'WTF::RefPtr<T>& WTF::RefPtr<T>::operator=(const WTF::PassRefPtr<T>&)
operator need destructor of object.

If you think that forward declared is better, I'll move this function's
definition to source file.

[vivekg, 2015/03/13 07:13:15]

No that won't be necessary. Let it be as is because this is a trivial setter no
need to move to cpp.

 #include "core/dom/ActiveDOMObject.h"
 #include "modules/EventTargetModules.h"
 #include "platform/AsyncMethodRunner.h"
@@ -47,6 +48,7 @@ namespace blink {
 class ExecutionContext;
 class NotificationOptions;
 class NotificationPermissionCallback;
+class ScriptState;
 struct WebNotificationData;
 
 class Notification final : public RefCountedGarbageCollectedEventTargetWithInlineData<Notification>, public ActiveDOMObject, public WebNotificationDelegate {
@@ -83,6 +85,8 @@ public:
     String tag() const { return m_tag; }
     String icon() const { return m_iconUrl; }
     bool silent() const { return m_silent; }
+    ScriptValue data(ScriptState*);
+    SerializedScriptValue* serializedData() const { return m_dataAsSerializedScriptValue.get(); }
 
     TextDirection direction() const;
     KURL iconURL() const { return m_iconUrl; }
@@ -121,6 +125,7 @@ private:
     void setIconUrl(KURL iconUrl) { m_iconUrl = iconUrl; }
     void setTag(const String& tag) { m_tag = tag; }
     void setSilent(bool silent) { m_silent = silent; }
+    void setSerializedData(PassRefPtr<SerializedScriptValue> data) { m_dataAsSerializedScriptValue = data; }

[Peter Beverloo, 2015/03/12 20:30:46]

nit: the setter's name should match the member it sets.

Renaming m_dataAsSerializedScriptValue to m_serializedData SGTM.

[Sanghyun Park, 2015/03/13 02:57:07]

I'll change this name

 
     void setPersistentId(const String& persistentId) { m_persistentId = persistentId; }
 
@@ -131,6 +136,7 @@ private:
     String m_body;
     String m_tag;
     bool m_silent;
+    RefPtr<SerializedScriptValue> m_dataAsSerializedScriptValue;
 
     KURL m_iconUrl;