Add the data attribute to the Notification object

Source/modules/notifications/Notification.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef Notification_h
 #define Notification_h
 
+#include "bindings/core/v8/SerializedScriptValue.h"

[vivekg, 2015/03/13 04:21:49]

nit: SerializedScriptValue can be forward declared.

[Sanghyun Park, 2015/03/13 05:03:08]

This header is required, becuase build break is occurred in "void
setSerializedData(PassRefPtr<SerializedScriptValue> data) {
m_dataAsSerializedScriptValue = data; }"
Because 'WTF::RefPtr<T>& WTF::RefPtr<T>::operator=(const WTF::PassRefPtr<T>&)
operator need destructor of object.

If you think that forward declared is better, I'll move this function's
definition to source file.

[vivekg, 2015/03/13 07:13:15]

No that won't be necessary. Let it be as is because this is a trivial setter no
need to move to cpp.

 #include "core/dom/ActiveDOMObject.h"
 #include "modules/EventTargetModules.h"
 #include "platform/AsyncMethodRunner.h"
 #include "platform/heap/Handle.h"
 #include "platform/text/TextDirection.h"
 #include "platform/weborigin/KURL.h"
 #include "public/platform/modules/notifications/WebNotificationDelegate.h"
 #include "public/platform/modules/notifications/WebNotificationPermission.h"
 #include "wtf/PassOwnPtr.h"
 #include "wtf/RefCounted.h"
 
 namespace blink {
 
 class ExecutionContext;
 class NotificationOptions;
 class NotificationPermissionCallback;
+class ScriptState;
 struct WebNotificationData;
 
 class Notification final : public RefCountedGarbageCollectedEventTargetWithInlineData<Notification>, public ActiveDOMObject, public WebNotificationDelegate {
     DEFINE_EVENT_TARGET_REFCOUNTING_WILL_BE_REMOVED(RefCountedGarbageCollected<Notification>);
     WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(Notification);
     DEFINE_WRAPPERTYPEINFO();
 public:
     // Used for JavaScript instantiations of the Notification object. Will automatically schedule for
     // the notification to be displayed to the user.
     static Notification* create(ExecutionContext*, const String& title, const NotificationOptions&, ExceptionState&);
@@ skipping 16 matching lines @@
     void dispatchErrorEvent() override;
     void dispatchCloseEvent() override;
 
     String title() const { return m_title; }
     String dir() const { return m_dir; }
     String lang() const { return m_lang; }
     String body() const { return m_body; }
     String tag() const { return m_tag; }
     String icon() const { return m_iconUrl; }
     bool silent() const { return m_silent; }
+    ScriptValue data(ScriptState*);
+    SerializedScriptValue* serializedData() const { return m_dataAsSerializedScriptValue.get(); }
 
     TextDirection direction() const;
     KURL iconURL() const { return m_iconUrl; }
 
     static String permissionString(WebNotificationPermission);
     static String permission(ExecutionContext*);
     static WebNotificationPermission checkPermission(ExecutionContext*);
     static void requestPermission(ExecutionContext*, NotificationPermissionCallback* = nullptr);
 
     // EventTarget interface.
@@ skipping 18 matching lines @@
     // until the operation completes. Otherwise, you need to hold a ref on this
     // instance until the operation completes.
     void show();
 
     void setDir(const String& dir) { m_dir = dir; }
     void setLang(const String& lang) { m_lang = lang; }
     void setBody(const String& body) { m_body = body; }
     void setIconUrl(KURL iconUrl) { m_iconUrl = iconUrl; }
     void setTag(const String& tag) { m_tag = tag; }
     void setSilent(bool silent) { m_silent = silent; }
+    void setSerializedData(PassRefPtr<SerializedScriptValue> data) { m_dataAsSerializedScriptValue = data; }

[Peter Beverloo, 2015/03/12 20:30:46]

nit: the setter's name should match the member it sets.

Renaming m_dataAsSerializedScriptValue to m_serializedData SGTM.

[Sanghyun Park, 2015/03/13 02:57:07]

I'll change this name

 
     void setPersistentId(const String& persistentId) { m_persistentId = persistentId; }
 
 private:
     String m_title;
     String m_dir;
     String m_lang;
     String m_body;
     String m_tag;
     bool m_silent;
+    RefPtr<SerializedScriptValue> m_dataAsSerializedScriptValue;
 
     KURL m_iconUrl;
 
     // Notifications can either be bound to the page, which means they're identified by
     // their delegate, or persistent, which means they're identified by a persistent Id
     // given to us by the embedder. This influences how we close the notification.
     String m_persistentId;
 
     enum NotificationState {
         NotificationStateIdle,
         NotificationStateShowing,
         NotificationStateClosing,
         NotificationStateClosed
     };
 
     // Only to be used by the Notification::create() method when notifications were created
     // by the embedder rather than by Blink.
     void setState(NotificationState state) { m_state = state; }
 
     NotificationState m_state;
 
     AsyncMethodRunner<Notification> m_asyncRunner;
 };
 
 } // namespace blink
 
 #endif // Notification_h