Source/modules/notifications/NotificationOptions.idl - Issue 993893002: Add the data attribute to the Notification object

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/notifications/NotificationOptions.idl

Issue 993893002: Add the data attribute to the Notification object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: [WIP] modified wrong comment. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/notifications/Notification.idl ('K') | « Source/modules/notifications/Notification.idl ('k') | Source/modules/notifications/ServiceWorkerRegistrationNotifications.h » ('j') | Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // http://notifications.spec.whatwg.org/#api	5 // http://notifications.spec.whatwg.org/#api

6	6

7 enum NotificationDirection {	7 enum NotificationDirection {

8 "auto",	8 "auto",

9 "ltr",	9 "ltr",

10 "rtl"	10 "rtl"

11 };	11 };

12	12

13 dictionary NotificationOptions {	13 dictionary NotificationOptions {

14 NotificationDirection dir = "auto";	14 NotificationDirection dir = "auto";

15 DOMString lang = "";	15 DOMString lang = "";

16 DOMString body = "";	16 DOMString body = "";

17 DOMString tag = "";	17 DOMString tag = "";

18 DOMString icon;	18 DOMString icon;

19 boolean silent = false;	19 boolean silent = false;

	20 any data = null;
	Peter Beverloo 2015/03/10 23:34:26 While we don't actually generate code for it in th While we don't actually generate code for it in the bindings, would you mind prefixing this with [RuntimeEnabled=] when you add the runtime enabled feature I noted in a comment slightly further on? It'll help readability :-). Sanghyun Park 2015/03/11 10:59:52 I'll add [RuntimeEnabled=NotificationExperimental] Show quoted text On 2015/03/10 23:34:26, Peter Beverloo wrote: > While we don't actually generate code for it in the bindings, would you mind > prefixing this with [RuntimeEnabled=] when you add the runtime enabled feature I > noted in a comment slightly further on? > > It'll help readability :-). I'll add [RuntimeEnabled=NotificationExperimental] like Notification.idl
20 };	21 };

OLD	NEW