Source/modules/notifications/ServiceWorkerRegistrationNotifications.h - Issue 993893002: Add the data attribute to the Notification object

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/notifications/ServiceWorkerRegistrationNotifications.h

Issue 993893002: Add the data attribute to the Notification object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: [WIP] modified wrong comment. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ServiceWorkerRegistrationNotifications_h	5 #ifndef ServiceWorkerRegistrationNotifications_h

6 #define ServiceWorkerRegistrationNotifications_h	6 #define ServiceWorkerRegistrationNotifications_h

7	7

8 #include "bindings/core/v8/ScriptPromise.h"	8 #include "bindings/core/v8/ScriptPromise.h"

9 #include "modules/serviceworkers/ServiceWorkerRegistration.h"	9 #include "modules/serviceworkers/ServiceWorkerRegistration.h"

10	10

11 namespace blink {	11 namespace blink {

12	12

13 class NotificationOptions;	13 class NotificationOptions;

14 class ScriptState;	14 class ScriptState;

15	15

16 class ServiceWorkerRegistrationNotifications {	16 class ServiceWorkerRegistrationNotifications {

17 public:	17 public:

18 static ScriptPromise showNotification(ScriptState*, ServiceWorkerRegistratio n&, const String& title, const NotificationOptions&);	18 static ScriptPromise showNotification(ScriptState*, ServiceWorkerRegistratio n&, const String& title, const NotificationOptions&, ExceptionState&);

19 };	19 };

20	20

21 } // namespace blink	21 } // namespace blink

22	22

23 #endif // ServiceWorkerRegistrationNotifications_h	23 #endif // ServiceWorkerRegistrationNotifications_h

OLD	NEW