Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 993613007: [Android] Add slack to allow refresh after overscrolling (Closed)

Created:
5 years, 9 months ago by jdduke (slow)
Modified:
5 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add slack to allow refresh after overscrolling Allow pull-to-refresh activation when the overscroll glow effect is active but mostly transparent. This accomodates accidental refresh prevention while easing the frustration of having to wait until the overscroll glow has completely faded. BUG=428429 Committed: https://crrev.com/9349a45e5ed98cfba24903bf573435aa1301e0da Cr-Commit-Position: refs/heads/master@{#320986}

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -7 lines) Patch
M content/browser/android/edge_effect.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/edge_effect.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/android/edge_effect_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/edge_effect_l.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/edge_effect_l.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/android/overscroll_controller_android.cc View 1 2 chunks +19 lines, -7 lines 0 comments Download
M content/browser/android/overscroll_glow.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/android/overscroll_glow.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jdduke (slow)
Ted, could you take a look? If you want, you can play with it, but ...
5 years, 9 months ago (2015-03-16 23:46:57 UTC) #3
Ted C
lgtm
5 years, 9 months ago (2015-03-17 20:21:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993613007/40001
5 years, 9 months ago (2015-03-17 21:45:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 9 months ago (2015-03-17 21:50:35 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 21:51:41 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9349a45e5ed98cfba24903bf573435aa1301e0da
Cr-Commit-Position: refs/heads/master@{#320986}

Powered by Google App Engine
This is Rietveld 408576698