Issue 993533005: Hide src/core Skia headers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 993533005: Hide src/core Skia headers (Closed)

Created:
5 years, 9 months ago by f(malita)

Modified:
5 years, 9 months ago

Reviewers:
mtklein_C, robertphillips, reed1

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Hide src/core Skia headers With a standalone BenchmarkingCanvas, we can now unexport the src/core headers. Also remove unused SkDebugCanvas sources. BUG=457691 R=reed@google.com,robertphillips@google.com,mtklein@chromium.org Committed: https://crrev.com/968d915fa6732be9fc42e1e1db8850c4576f60bd Cr-Commit-Position: refs/heads/master@{#319874}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -19 lines)			Patch
M	skia/BUILD.gn	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	skia/skia_gn_files.gypi	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	skia/skia_library.gypi	View	2 chunks	+0 lines, -10 lines	0 comments	Download

Total messages: 7 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993533005/1

5 years, 9 months ago (2015-03-10 13:58:02 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-10 14:01:49 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/968d915fa6732be9fc42e1e1db8850c4576f60bd
Cr-Commit-Position: refs/heads/master@{#319874}