Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: skia/BUILD.gn

Issue 993533005: Hide src/core Skia headers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | skia/skia_gn_files.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/BUILD.gn
diff --git a/skia/BUILD.gn b/skia/BUILD.gn
index e2223470e43ef1b65b41a540f9439ce5be0e19fb..248bc1cff3483845385662604bcdcce3ea3b0ca4 100644
--- a/skia/BUILD.gn
+++ b/skia/BUILD.gn
@@ -128,9 +128,6 @@ config("skia_config") {
"//third_party/skia/include/pipe",
"//third_party/skia/include/ports",
"//third_party/skia/include/utils",
-
- # need to move this to internal. see crbug.com/457691
- "//third_party/skia/src/core",
]
defines = gypi_blink_skia_defines.blink_skia_defines
@@ -173,6 +170,7 @@ config("skia_library_config") {
# exported to dependents. It's not clear if this is on purpose, but this
# matches the GYP build.
include_dirs = [
+ "//third_party/skia/src/core",
"//third_party/skia/src/image",
"//third_party/skia/src/opts",
"//third_party/skia/src/pdf",
« no previous file with comments | « no previous file | skia/skia_gn_files.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698