Chromium Code Reviews

Issue 993513008: xfail the go bindings test for now. They fail if we use cmake w/ libc++. (Closed)

Created:
5 years, 9 months ago by jvoung (off chromium)
Modified:
5 years, 8 months ago
Reviewers:
Karl, Jim Stichnoth, Derek Schuff
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add more info #

Unified diffs Side-by-side diffs Stats (+11 lines, -0 lines)
M test/Bindings/Go/go.test View 1 chunk +11 lines, -0 lines 0 comments

Messages

Total messages: 5 (2 generated)
jvoung (off chromium)
5 years, 8 months ago (2015-04-09 23:11:19 UTC) #3
Derek Schuff
lgtm
5 years, 8 months ago (2015-04-10 15:53:32 UTC) #4
jvoung (off chromium)
5 years, 8 months ago (2015-04-10 17:47:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1c2128926f048a5bc99342e8d0af2793d69422ab (presubmit successful).

Powered by Google App Engine