Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/Bindings/Go/go.test

Issue 993513008: xfail the go bindings test for now. They fail if we use cmake w/ libc++. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Patch Set: add more info Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/Bindings/Go/go.test
diff --git a/test/Bindings/Go/go.test b/test/Bindings/Go/go.test
index 3951483b6ffb486f9c72ce491a01e508f5ede7cd..e0f466811b64cba804b40b6ba85db41323f6d16c 100644
--- a/test/Bindings/Go/go.test
+++ b/test/Bindings/Go/go.test
@@ -1,3 +1,14 @@
+; @LOCALMOD-BEGIN
+; Disable this for now to allow cmake builds with libc++.
+; The bindings test tries build a bunch of things and then link against
+; the LLVM libraries, but the build script that it uses within the test
+; does not pick up changes to CMAKE_C*_FLAGS so if we change that then
+; the link commandline is wrong:
+; https://llvm.org/bugs/show_bug.cgi?id=21552
+; https://code.google.com/p/nativeclient/issues/detail?id=4119
+; Add "-x" to the below commandline to get more verbose output.
+; XFAIL: *
+; @LOCALMOD-END
; RUN: llvm-go test llvm.org/llvm/bindings/go/llvm
; REQUIRES: shell
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698