Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 993513006: Introduce ManagePasswordsState class. (Closed)

Created:
5 years, 9 months ago by vasilii
Modified:
5 years, 9 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce ManagePasswordsState class. It will simplify ManagePasswordsUIController. The tests are the same as in ManagePasswordsUIControllerTest. BUG=461801 Committed: https://crrev.com/910f1ec6f2cdb93dc6278873bd52d23069cb5a1f Cr-Commit-Position: refs/heads/master@{#319864}

Patch Set 1 #

Total comments: 16

Patch Set 2 : comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+753 lines, -16 lines) Patch
M chrome/browser/ui/passwords/manage_passwords_bubble_model.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/browser/ui/passwords/manage_passwords_state.h View 1 1 chunk +147 lines, -0 lines 0 comments Download
A chrome/browser/ui/passwords/manage_passwords_state.cc View 1 1 chunk +264 lines, -0 lines 1 comment Download
A chrome/browser/ui/passwords/manage_passwords_state_unittest.cc View 1 1 chunk +318 lines, -0 lines 1 comment Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.h View 1 chunk +7 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager_unittest.cc View 9 chunks +8 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
vasilii
Hi Vaclav, please review. The CL is big but it copies the logic from ManagePasswordsUIController. ...
5 years, 9 months ago (2015-03-09 18:41:30 UTC) #2
vabr (Chromium)
LGTM with comments. Could you perhaps also place remove-TODOs in the ManagePasswordsUIController parts which are ...
5 years, 9 months ago (2015-03-10 10:39:57 UTC) #3
vasilii
I'll touch the whole ManagePasswordsUIController but I added a TODO. https://codereview.chromium.org/993513006/diff/1/chrome/browser/ui/passwords/manage_passwords_state.cc File chrome/browser/ui/passwords/manage_passwords_state.cc (right): https://codereview.chromium.org/993513006/diff/1/chrome/browser/ui/passwords/manage_passwords_state.cc#newcode57 ...
5 years, 9 months ago (2015-03-10 11:34:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993513006/20001
5 years, 9 months ago (2015-03-10 11:35:55 UTC) #7
vabr (Chromium)
Still LGTM, although with some minor comments. Cheers, Vaclav https://codereview.chromium.org/993513006/diff/20001/chrome/browser/ui/passwords/manage_passwords_state.cc File chrome/browser/ui/passwords/manage_passwords_state.cc (right): https://codereview.chromium.org/993513006/diff/20001/chrome/browser/ui/passwords/manage_passwords_state.cc#newcode57 chrome/browser/ui/passwords/manage_passwords_state.cc:57: ...
5 years, 9 months ago (2015-03-10 12:26:22 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-10 12:31:26 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 12:32:15 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/910f1ec6f2cdb93dc6278873bd52d23069cb5a1f
Cr-Commit-Position: refs/heads/master@{#319864}

Powered by Google App Engine
This is Rietveld 408576698