Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Issue 993513006: Introduce ManagePasswordsState class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
7 7
8 #include "base/memory/scoped_vector.h" 8 #include "base/memory/scoped_vector.h"
9 #include "base/timer/elapsed_timer.h" 9 #include "base/timer/elapsed_timer.h"
10 #include "components/autofill/core/common/password_form.h" 10 #include "components/autofill/core/common/password_form.h"
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 virtual void UpdateAndroidAccountChooserInfoBarVisibility(); 182 virtual void UpdateAndroidAccountChooserInfoBarVisibility();
183 183
184 // The current state of the password manager UI. 184 // The current state of the password manager UI.
185 password_manager::ui::State state_; 185 password_manager::ui::State state_;
186 186
187 // Used to measure the amount of time on a page; if it's less than some 187 // Used to measure the amount of time on a page; if it's less than some
188 // reasonable limit, then don't close the bubble upon navigation. We create 188 // reasonable limit, then don't close the bubble upon navigation. We create
189 // (and destroy) the timer in DidNavigateMainFrame. 189 // (and destroy) the timer in DidNavigateMainFrame.
190 scoped_ptr<base::ElapsedTimer> timer_; 190 scoped_ptr<base::ElapsedTimer> timer_;
191 191
192 // TODO(vasilii): remove these data variables, use ManagePasswordsState.
193
192 // Set by OnPasswordSubmitted() when the user submits a form containing login 194 // Set by OnPasswordSubmitted() when the user submits a form containing login
193 // information. If the user responds to a subsequent "Do you want to save 195 // information. If the user responds to a subsequent "Do you want to save
194 // this password?" prompt, we ask this object to save or blacklist the 196 // this password?" prompt, we ask this object to save or blacklist the
195 // associated login information in Chrome's password store. 197 // associated login information in Chrome's password store.
196 scoped_ptr<password_manager::PasswordFormManager> form_manager_; 198 scoped_ptr<password_manager::PasswordFormManager> form_manager_;
197 199
198 // We create copies of PasswordForm objects that come in with unclear lifetime 200 // We create copies of PasswordForm objects that come in with unclear lifetime
199 // and store them in this vector as well as in |password_form_map_| to ensure 201 // and store them in this vector as well as in |password_form_map_| to ensure
200 // that we destroy them correctly. If |new_password_forms_| gets cleared then 202 // that we destroy them correctly. If |new_password_forms_| gets cleared then
201 // |password_form_map_| is to be cleared too. 203 // |password_form_map_| is to be cleared too.
(...skipping 17 matching lines...) Expand all
219 221
220 // The origin of the form we're currently dealing with; we'll use this to 222 // The origin of the form we're currently dealing with; we'll use this to
221 // determine which PasswordStore changes we should care about when updating 223 // determine which PasswordStore changes we should care about when updating
222 // |password_form_map_|. 224 // |password_form_map_|.
223 GURL origin_; 225 GURL origin_;
224 226
225 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController); 227 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController);
226 }; 228 };
227 229
228 #endif // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_ 230 #endif // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698