Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Issue 993423004: Fix normalization of relative paths inside of deep relative imports (Closed)

Created:
5 years, 9 months ago by jakemac
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-components.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix normalization of relative paths inside of deep relative imports R=sigmund@google.com Committed: https://github.com/dart-lang/core-elements/commit/ce72479ab94a6306825a72874f17f73ff25761ac

Patch Set 1 #

Total comments: 1

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -20 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/build/html_import_annotation_recorder.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download
M lib/build/import_crawler.dart View 1 3 chunks +11 lines, -7 lines 0 comments Download
M lib/build/import_inliner.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/build/import_crawler_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M test/build/import_inliner_test.dart View 1 chunk +22 lines, -0 lines 0 comments Download
M test/custom_element_test.dart View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
jakemac
5 years, 9 months ago (2015-03-11 20:41:19 UTC) #2
jakemac
5 years, 9 months ago (2015-03-11 20:41:20 UTC) #3
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/993423004/diff/1/lib/build/import_crawler.dart File lib/build/import_crawler.dart (right): https://codereview.chromium.org/993423004/diff/1/lib/build/import_crawler.dart#newcode51 lib/build/import_crawler.dart:51: Future doCrawl(AssetId assetId, {Element import, Document document, AssetId ...
5 years, 9 months ago (2015-03-11 21:47:54 UTC) #4
jakemac
5 years, 9 months ago (2015-03-11 22:27:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ce72479ab94a6306825a72874f17f73ff25761ac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698