Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 993343006: [CleanUp] Remove parameter |by_user| in NotificationClosed (Closed)

Created:
5 years, 9 months ago by zhuoyu.qian
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-notifications_chromium.org, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CleanUp] Remove parameter |by_user| in NotificationClosed As the comment in page_notification_delegate.cc by peter@, Remove parameter |by_user| in function NotificationClosed. BUG= R=peter@chromium.org, jochen@chromium.org Committed: https://crrev.com/dddf7dfdd489bea6d8d952c0981957b9c36b3926 Cr-Commit-Position: refs/heads/master@{#320433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chrome/browser/notifications/notification_object_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/platform_notification_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/notifications/page_notification_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/notifications/page_notification_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/browser/desktop_notification_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_notification_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
zhuoyu.qian
Hi Peter: I'd like you to take a look at: chrome/browser/notifications/* Hi jochen: I'd like ...
5 years, 9 months ago (2015-03-12 02:07:42 UTC) #1
Peter Beverloo
heh, cool. lgtm Extensions do still expose this to developers, so we can't do cleanups ...
5 years, 9 months ago (2015-03-12 02:17:29 UTC) #2
zhuoyu.qian
On 2015/03/12 02:17:29, Peter Beverloo wrote: > heh, cool. lgtm > > Extensions do still ...
5 years, 9 months ago (2015-03-12 02:19:57 UTC) #3
Peter Beverloo
On 2015/03/12 02:19:57, zhuoyu.qian wrote: > On 2015/03/12 02:17:29, Peter Beverloo wrote: > > heh, ...
5 years, 9 months ago (2015-03-12 02:21:37 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-12 15:08:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993343006/1
5 years, 9 months ago (2015-03-13 01:05:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-13 02:11:49 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 02:12:23 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dddf7dfdd489bea6d8d952c0981957b9c36b3926
Cr-Commit-Position: refs/heads/master@{#320433}

Powered by Google App Engine
This is Rietveld 408576698