content/browser/notifications/page_notification_delegate.cc - Issue 993343006: [CleanUp] Remove parameter |by_user| in NotificationClosed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/page_notification_delegate.cc

Issue 993343006: [CleanUp] Remove parameter |by_user| in NotificationClosed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/notifications/page_notification_delegate.h ('k') | content/public/browser/desktop_notification_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/page_notification_delegate.cc

diff --git a/content/browser/notifications/page_notification_delegate.cc b/content/browser/notifications/page_notification_delegate.cc

index dacfffbfd22da5db3bdede2ead526dd7b294d480..fdf085d7c7ca6bc48b846ec9fb2b8427938d2417 100644

--- a/content/browser/notifications/page_notification_delegate.cc

+++ b/content/browser/notifications/page_notification_delegate.cc

@@ -26,8 +26,7 @@ void PageNotificationDelegate::NotificationDisplayed() {

sender->Send(new PlatformNotificationMsg_DidShow(notification_id_));

}

-// TODO(peter): Remove |by_user| since we're not using that anywhere.

-void PageNotificationDelegate::NotificationClosed(bool by_user) {

+void PageNotificationDelegate::NotificationClosed() {

RenderProcessHost* sender = RenderProcessHost::FromID(render_process_id_);

if (!sender)

return;