Issue 99333020: Remove -fstack-protector-strong from the ChromeOS GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99333020: Remove -fstack-protector-strong from the ChromeOS GN build. (Closed)

Created:
6 years, 11 months ago by brettw

Modified:
6 years, 11 months ago

Reviewers:
jam

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove -fstack-protector-strong from the ChromeOS GN build. This trybots said this was an unknown option, so the comment I was basing my usage of "strong" on in common.gypi must be out-of-date. The GYP build does not seem to specify "strong" in any cases except on Mac. Hook up compiler finding to the Android build. R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242746

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : testing stuff #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -39 lines)			Patch
M	build/config/compiler/BUILD.gn	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	build/toolchain/android/BUILD.gn	View	1 2 7	1 chunk	+2 lines, -4 lines	0 comments	Download
A +	build/toolchain/android/find_android_compiler.py	View	1 2 3 4 5 6 7 8	1 chunk	+11 lines, -1 line	0 comments	Download
D	build/toolchain/linux/find_android_compilers.py	View		1 chunk	+0 lines, -31 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

6 years, 11 months ago (2013-12-31 05:00:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #9 manually as r242746 (presubmit successful).

Expand Messages | Collapse Messages