Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4153)

Unified Diff: build/toolchain/android/BUILD.gn

Issue 99333020: Remove -fstack-protector-strong from the ChromeOS GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | build/toolchain/android/find_android_compiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/android/BUILD.gn
diff --git a/build/toolchain/android/BUILD.gn b/build/toolchain/android/BUILD.gn
index 7710cd0f9962b013efb5be10429ccdf1ccbd72e4..c277263db1c7752ec640939b2c4f95c57f9ef87f 100644
--- a/build/toolchain/android/BUILD.gn
+++ b/build/toolchain/android/BUILD.gn
@@ -44,10 +44,8 @@ if (is_gyp) {
# This script will find the compilers for the given Android toolchain
# directory.
- # TODO(brettw) write this script which locates the Android compilers.
- #android_compilers = exec_script("find_android_compilers.py",
- # [android_toolchain], "value")
- android_compilers = ["gcc", "g++", "gcc", "g++"]
+ android_compilers = exec_script("find_android_compiler.py",
+ [android_toolchain], "value")
gyp_header =
"'make_global_settings': [" +
"['CC', '" + android_compilers[0] + "']," +
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | build/toolchain/android/find_android_compiler.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698