IDL compiler: simplify type conversion in Event Constructor

Source/bindings/v8/Dictionary.h

Index: Source/bindings/v8/Dictionary.h
diff --git a/Source/bindings/v8/Dictionary.h b/Source/bindings/v8/Dictionary.h
index 93ea467cbe8b6f09289a4d4ff640f78ac2d5615f..302c6408d75b882a845426a7dd29835683c8dbaf 100644
--- a/Source/bindings/v8/Dictionary.h
+++ b/Source/bindings/v8/Dictionary.h
@@ -119,11 +119,7 @@ public:
         String typeName() const { return m_propertyTypeName; }
         IntegerConversionConfiguration numberConversion() const { return m_numberConversion; }
 
-        ConversionContext& withAttributes(bool, IntegerConversionConfiguration, const String&);
-        ConversionContext& withAttributes(bool, IntegerConversionConfiguration);
-        ConversionContext& withAttributes(bool, const String&);
-        ConversionContext& withAttributes(bool);
-        ConversionContext& withAttributes(const String&);
+        ConversionContext& conversionType(bool, IntegerConversionConfiguration, const String&);

[haraken, 2013/12/11 08:26:23]

I would rename it to setConversionType and reorder the parameters like:

  setConversionType(const String&, bool, IntegerConversionConfiguration)

since the type parameter is always necessary.

[Nils Barth (inactive), 2013/12/11 08:51:31]

Done (and removed the integer conversion);
that's clearer, as it's (type, isNullable): basic, auxiliary.

 
         void throwTypeError(const String& detail);