Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp - Issue 99333017: IDL compiler: simplify type conversion in Event Constructor

Unified Diff: Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp

Issue 99333017: IDL compiler: simplify type conversion in Event Constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/code_generator_v8.pm ('K') | « Source/bindings/tests/results/V8TestExtendedEvent.cpp ('k') | Source/bindings/v8/Dictionary.h » ('j') | Source/bindings/v8/Dictionary.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp b/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp

index f088fa8e1fe4a3a1a3e47909ee121905e77cf124..2c21ed89f05beb951595998b5ee6e8c5aa02e33e 100644

--- a/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp

@@ -205,17 +205,17 @@ bool initializeTestInterfaceEventConstructor(TestInterfaceEventConstructorInit&

if (!initializeEvent(eventInit, options, exceptionState, forEventName.isEmpty() ? String("TestInterfaceEventConstructor") : forEventName))

return false;

- if (!options.convert(conversionContext, "initializedByEventConstructorReadonlyStringAttribute", eventInit.initializedByEventConstructorReadonlyStringAttribute))

+ if (!options.convert(conversionContext.conversionType(false, NormalConversion, "DOMString"), "initializedByEventConstructorReadonlyStringAttribute", eventInit.initializedByEventConstructorReadonlyStringAttribute))

return false;

- if (options.convert(conversionContext, "deprecatedInitializedByEventConstructorReadonlyStringAttribute", eventInit.deprecatedInitializedByEventConstructorReadonlyStringAttribute)) {

+ if (options.convert(conversionContext.conversionType(false, NormalConversion, "DOMString"), "deprecatedInitializedByEventConstructorReadonlyStringAttribute", eventInit.deprecatedInitializedByEventConstructorReadonlyStringAttribute)) {

if (options.hasProperty("deprecatedInitializedByEventConstructorReadonlyStringAttribute"))

UseCounter::countDeprecation(activeExecutionContext(), UseCounter::initializedByEventConstructorReadonlyStringAttribute);

} else {

return false;

}

- if (!options.convert(conversionContext, "implementedAsInitializedByEventConstructorReadonlyStringAttribute", eventInit.implementedAsName))

+ if (!options.convert(conversionContext.conversionType(false, NormalConversion, "DOMString"), "implementedAsInitializedByEventConstructorReadonlyStringAttribute", eventInit.implementedAsName))

return false;

- if (options.convert(conversionContext, "deprecatedImplementedAsInitializedByEventConstructorReadonlyStringAttribute", eventInit.deprecatedImplementedAsName)) {

+ if (options.convert(conversionContext.conversionType(false, NormalConversion, "DOMString"), "deprecatedImplementedAsInitializedByEventConstructorReadonlyStringAttribute", eventInit.deprecatedImplementedAsName)) {

if (options.hasProperty("deprecatedImplementedAsInitializedByEventConstructorReadonlyStringAttribute"))

UseCounter::countDeprecation(activeExecutionContext(), UseCounter::initializedByEventConstructorReadonlyStringAttribute);

} else {