IDL compiler: simplify type conversion in Event Constructor

IDL compiler: simplify type conversion in Event Constructor

The current Dictionary::ConversionContext.withAttributes method is
code-generator unfriendly (no need for overloading, since we're generating
the code), and confusingly named.

This removes the unnecessary complexity of overloading, and renames
it to the clearer ConversionContext.conversionType.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163704

[Nils Barth (inactive), 2013-12-11 08:14:19]

Here's the simplifying CL (*much* simpler).
* How's the naming?
* We could remove the integer conversion completely, as it's not used at
present.

https://codereview.chromium.org/99333017/diff/1/Source/bindings/scripts/code_...
File Source/bindings/scripts/code_generator_v8.pm (right):

https://codereview.chromium.org/99333017/diff/1/Source/bindings/scripts/code_...
Source/bindings/scripts/code_generator_v8.pm:3024: my $numberConversion;
This is actually never used -- it's always NormalConversion.
We might want to keep it for future use, but otherwise we could
remove it, simplifying Dictionary.(h|cpp) a bit more.

[haraken, 2013-12-11 08:26:23]

LGTM

https://codereview.chromium.org/99333017/diff/1/Source/bindings/v8/Dictionary.h
File Source/bindings/v8/Dictionary.h (right):

https://codereview.chromium.org/99333017/diff/1/Source/bindings/v8/Dictionary...
Source/bindings/v8/Dictionary.h:122: ConversionContext& conversionType(bool,
IntegerConversionConfiguration, const String&);

I would rename it to setConversionType and reorder the parameters like:

  setConversionType(const String&, bool, IntegerConversionConfiguration)

since the type parameter is always necessary.

[Nils Barth (inactive), 2013-12-11 08:51:31]

https://codereview.chromium.org/99333017/diff/1/Source/bindings/v8/Dictionary.h
File Source/bindings/v8/Dictionary.h (right):

https://codereview.chromium.org/99333017/diff/1/Source/bindings/v8/Dictionary...
Source/bindings/v8/Dictionary.h:122: ConversionContext& conversionType(bool,
IntegerConversionConfiguration, const String&);
On 2013/12/11 08:26:23, haraken wrote:
> 
> I would rename it to setConversionType and reorder the parameters like:
> 
>   setConversionType(const String&, bool, IntegerConversionConfiguration)
> 
> since the type parameter is always necessary.

Done (and removed the integer conversion);
that's clearer, as it's (type, isNullable): basic, auxiliary.

[Nils Barth (inactive), 2013-12-11 08:52:12]

Hi haraken,
could you PTAL?
I've removed the integer conversion code,
and accordingly simplified Dictionary.h a bit further,
notably flattening out some of the logic.

[haraken, 2013-12-11 08:54:01]

LGTM.

[Nils Barth (inactive), 2013-12-11 08:56:58]

On 2013/12/11 08:54:01, haraken wrote:
> LGTM.

Thanks!

[commit-bot: I haz the power, 2013-12-11 08:57:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/99333017/40001

[commit-bot: I haz the power, 2013-12-11 10:37:55]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[Nils Barth (inactive), 2013-12-11 11:12:32]

On 2013/12/11 10:37:55, I haz the power (commit-bot) wrote:
> Retried try job too often on linux_blink_rel for step(s) webkit_tests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

Error message text changed b/c I removed the special-casing for (the rare)
|object| type.
Updated layout test result and also simplified the v8/ code a bit more, b/c no
longer
need to special case "missing type".

[commit-bot: I haz the power, 2013-12-11 11:12:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/99333017/60001

[commit-bot: I haz the power, 2013-12-11 13:00:51]

Change committed as 163704