IDL compiler: simplify type conversion in Event Constructor

Source/bindings/scripts/code_generator_v8.pm

 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
 # Copyright (C) 2006 Apple Computer, Inc.
 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
 # Copyright (C) 2012 Ericsson AB. All rights reserved.
@@ skipping 3002 matching lines @@
 
 END
     }
 
     foreach my $attribute (@{$interface->attributes}) {
         if ($attribute->extendedAttributes->{"InitializedByEventConstructor"}) {
             if ($attribute->type ne "any") {
                 my $attributeName = $attribute->name;
                 my $attributeImplName = GetImplName($attribute);
 
-                # Construct the arguments to the corresponding Dictionary.convert() method.
-                my @convertArguments = ();
+                my $isNullable = $attribute->isNullable ? "true" : "false";
+                my $numberConversion;

[Nils Barth (inactive), 2013/12/11 08:14:20]

This is actually never used -- it's always NormalConversion.
We might want to keep it for future use, but otherwise we could
remove it, simplifying Dictionary.(h|cpp) a bit more.

                 if ($attribute->extendedAttributes->{"EnforceRange"}) {
-                    push(@convertArguments, "EnforceRange");
+                    $numberConversion = "EnforceRange";
                 } elsif ($attribute->extendedAttributes->{"Clamp"}) {
-                    push(@convertArguments, "Clamp");
-                } elsif (IsIntegerType($attribute->type)) {
-                    push(@convertArguments, "NormalConversion");
-                } elsif ($attribute->type eq "boolean" || $attribute->type eq "double") {
-                    ;
-                } elsif ($attribute->type eq "DOMString" || IsEnumType($attribute->type) || IsCallbackFunctionType($attribute->type)) {
-                    ;
-                } elsif ($attribute->type ne "object") {
-                    push(@convertArguments, "\"" . $attribute->type . "\"");
+                    $numberConversion = "Clamp";
+                } else {
+                    $numberConversion = "NormalConversion";
                 }
-
-                my $withPropertyAttributes = "";
-                if (@convertArguments || $attribute->isNullable) {
-                    unshift(@convertArguments, $attribute->isNullable ? "true" : "false");
-                    $withPropertyAttributes = ".withAttributes(" . join(", ", @convertArguments) . ")";
-                }
-
-                my $dictionaryGetter = "options.convert(conversionContext${withPropertyAttributes}, \"$attributeName\", eventInit.$attributeImplName)";
+                my $dictionaryGetter = "options.convert(conversionContext.conversionType($isNullable, $numberConversion, \"" . $attribute->type . "\"), \"$attributeName\", eventInit.$attributeImplName)";
                 my $deprecation = $attribute->extendedAttributes->{"DeprecateAs"};
                 if ($deprecation) {
                     $code .= "    if ($dictionaryGetter) {\n";
                     $code .= "        if (options.hasProperty(\"$attributeName\"))\n";
                     $code .= "        " . GenerateDeprecationNotification($deprecation);
                     $code .= "    } else {\n";
                     $code .= "        return false;\n";
                     $code .= "    }\n";
                 } else {
                     $code .= "    if (!$dictionaryGetter)\n";
@@ skipping 3320 matching lines @@
 
     return 1 if ExtendedAttributeContains($interface->extendedAttributes->{"Custom"}, "ToV8");
     return 1 if ExtendedAttributeContains($interface->extendedAttributes->{"Custom"}, "Wrap");
     return 1 if $interface->extendedAttributes->{"SpecialWrapFor"};
     return 1 if InheritsInterface($interface, "Document");
 
     return 0;
 }
 
 1;