Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: Source/core/html/HTMLOptionElement.h

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLMetaElement-in.cpp ('k') | Source/core/html/HTMLOptionElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLOptionElement.h
diff --git a/Source/core/html/HTMLOptionElement.h b/Source/core/html/HTMLOptionElement.h
index f4a89061ea88246af5a492ad9e6e3ccb844d1bbd..f7103f8afd88dbe83aa18de8bee9cecb0a3e6b57 100644
--- a/Source/core/html/HTMLOptionElement.h
+++ b/Source/core/html/HTMLOptionElement.h
@@ -36,7 +36,7 @@ class HTMLSelectElement;
class HTMLOptionElement FINAL : public HTMLElement {
public:
static PassRefPtr<HTMLOptionElement> create(Document&);
- static PassRefPtr<HTMLOptionElement> createForJSConstructor(Document&, const String& data, const String& value,
+ static PassRefPtr<HTMLOptionElement> createForJSConstructor(Document&, const String& data, const AtomicString& value,
bool defaultSelected, bool selected, ExceptionState&);
virtual String text() const;
@@ -45,7 +45,7 @@ public:
int index() const;
String value() const;
- void setValue(const String&);
+ void setValue(const AtomicString&);
bool selected();
void setSelected(bool);
@@ -54,7 +54,7 @@ public:
HTMLSelectElement* ownerSelectElement() const;
String label() const;
- void setLabel(const String&);
+ void setLabel(const AtomicString&);
bool ownElementDisabled() const { return m_disabled; }
« no previous file with comments | « Source/core/html/HTMLMetaElement-in.cpp ('k') | Source/core/html/HTMLOptionElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698