Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 993223003: convert most remaining api functions needing context to maybes (Closed)

Created:
5 years, 9 months ago by dcarney
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

convert most remaining api functions needing context to maybes BUG= Committed: https://crrev.com/5234d9977d637668e66b9e2e9f0456c6f97f749e Cr-Commit-Position: refs/heads/master@{#27126}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -119 lines) Patch
M include/v8.h View 4 chunks +12 lines, -4 lines 0 comments Download
M include/v8-debug.h View 1 1 chunk +12 lines, -3 lines 0 comments Download
M src/api.cc View 1 12 chunks +104 lines, -112 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sven Panne
lgtm
5 years, 9 months ago (2015-03-11 09:30:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993223003/20001
5 years, 9 months ago (2015-03-11 09:30:42 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-11 09:33:03 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 09:33:14 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5234d9977d637668e66b9e2e9f0456c6f97f749e
Cr-Commit-Position: refs/heads/master@{#27126}

Powered by Google App Engine
This is Rietveld 408576698