Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: include/v8-debug.h

Issue 993223003: convert most remaining api functions needing context to maybes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8-debug.h
diff --git a/include/v8-debug.h b/include/v8-debug.h
index 6abf4e095bccadacdb6ef3fa4a3fc06fcbc76966..ae11a2aeea74fa7aa002296ccbb7d849081aed53 100644
--- a/include/v8-debug.h
+++ b/include/v8-debug.h
@@ -202,13 +202,22 @@ class V8_EXPORT Debug {
* }
* \endcode
*/
- static Local<Value> Call(v8::Handle<v8::Function> fun,
- Handle<Value> data = Handle<Value>());
+ static V8_DEPRECATE_SOON(
+ "Use maybe version",
+ Local<Value> Call(v8::Handle<v8::Function> fun,
+ Handle<Value> data = Handle<Value>()));
+ // TODO(dcarney): data arg should be a MaybeLocal
+ static MaybeLocal<Value> Call(Local<Context> context,
+ v8::Handle<v8::Function> fun,
+ Handle<Value> data = Handle<Value>());
/**
* Returns a mirror object for the given object.
*/
- static Local<Value> GetMirror(v8::Handle<v8::Value> obj);
+ static V8_DEPRECATE_SOON("Use maybe version",
+ Local<Value> GetMirror(v8::Handle<v8::Value> obj));
+ static MaybeLocal<Value> GetMirror(Local<Context> context,
+ v8::Handle<v8::Value> obj);
/**
* Makes V8 process all pending debug messages.
« no previous file with comments | « include/v8.h ('k') | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698