Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 993213003: Support browser caching using hashes in serverMode (fixes #93, fixes #92) (Closed)

Created:
5 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 9 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support browser caching using hashes in serverMode (fixes #93, fixes #92). Now the HTML can include a hash in the URL for cachable resources, and the serve knows how to include cache-control headers. In the process of doing so, I had to change a couple things that made it possible to fix #92 as well (producing different output in the command-line than in server mode).

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -103 lines) Patch
M bin/devc.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/devc.dart View 10 chunks +47 lines, -17 lines 0 comments Download
M lib/src/codegen/code_generator.dart View 1 chunk +4 lines, -1 line 0 comments Download
M lib/src/codegen/dart_codegen.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M lib/src/codegen/html_codegen.dart View 3 chunks +32 lines, -17 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M lib/src/dependency_graph.dart View 5 chunks +19 lines, -9 lines 0 comments Download
M lib/src/utils.dart View 3 chunks +11 lines, -0 lines 0 comments Download
M pubspec.yaml View 2 chunks +2 lines, -1 line 0 comments Download
A + test/codegen/expect/server_mode/dev_compiler/runtime/dart_runtime.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/codegen/expect/server_mode/dev_compiler/runtime/harmony_feature_check.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/codegen/expect/server_mode/dev_compiler/runtime/messages.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/codegen/expect/server_mode/dev_compiler/runtime/messages_widget.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/codegen/expect/server_mode/dir/html_input_a.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/codegen/expect/server_mode/dir/html_input_b.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/codegen/expect/server_mode/dir/html_input_c.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/codegen/expect/server_mode/dir/html_input_d.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/codegen/expect/server_mode/dir/html_input_e.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A test/codegen/expect/server_mode/html_input.html View 1 chunk +19 lines, -0 lines 0 comments Download
A + test/codegen/expect/server_mode/html_input.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/codegen_test.dart View 4 chunks +23 lines, -4 lines 0 comments Download
M test/dependency_graph_test.dart View 21 chunks +52 lines, -58 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-11 00:28:02 UTC) #3
vsm
lgtm
5 years, 9 months ago (2015-03-11 01:21:29 UTC) #4
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-11 01:30:11 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698