Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: lib/src/codegen/code_generator.dart

Issue 993213003: Support browser caching using hashes in serverMode (fixes #93, fixes #92) (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/devc.dart ('k') | lib/src/codegen/dart_codegen.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/codegen/code_generator.dart
diff --git a/lib/src/codegen/code_generator.dart b/lib/src/codegen/code_generator.dart
index cda50d156e6dfbad3081ba880ccf9dd3c30c20b4..c2920c49d109abc1ccbd74064bab522ebcb0b310 100644
--- a/lib/src/codegen/code_generator.dart
+++ b/lib/src/codegen/code_generator.dart
@@ -129,6 +129,9 @@ abstract class CodeGenerator {
CodeGenerator(String outDir, this.root, this.rules)
: outDir = path.absolute(outDir);
- void generateLibrary(Iterable<CompilationUnit> units, LibraryInfo info,
+ /// Return a hash, if any, that can be used for caching purposes. When two
+ /// invocations to this function return the same hash, the underlying
+ /// code-generator generated the same code.
+ String generateLibrary(Iterable<CompilationUnit> units, LibraryInfo info,
CheckerReporter reporter);
}
« no previous file with comments | « lib/devc.dart ('k') | lib/src/codegen/dart_codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698