Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 993153002: Sync: ChangeReorderBuffer::Traversal should handle nodes with unset Parent ID (Closed)

Created:
5 years, 9 months ago by stanisc
Modified:
5 years, 9 months ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync: ChangeReorderBuffer::Traversal should handle nodes with unset Parent ID When reording sync nodes for an update, treat sync nodes with implicit parent folder as if they were linked directly under the directory root. That is safe to do because only non-hierarchical datatype nodes might have unset parent IDs and those nodes are OK to handle in any order. BUG=438313 Committed: https://crrev.com/7c880b539f7ea8e13cbe6930b01fe38a1aad78b0 Cr-Commit-Position: refs/heads/master@{#320145}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -2 lines) Patch
M sync/internal_api/change_reorder_buffer.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
stanisc
Please take a look. This is one missing case for handling updates for nodes with ...
5 years, 9 months ago (2015-03-11 01:37:07 UTC) #3
pavely
lgtm
5 years, 9 months ago (2015-03-11 17:42:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993153002/20001
5 years, 9 months ago (2015-03-11 20:35:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-11 21:03:36 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 21:04:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c880b539f7ea8e13cbe6930b01fe38a1aad78b0
Cr-Commit-Position: refs/heads/master@{#320145}

Powered by Google App Engine
This is Rietveld 408576698