Sync: ChangeReorderBuffer::Traversal should handle nodes with unset Parent ID

sync/internal_api/sync_manager_impl_unittest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Unit tests for the SyncApi. Note that a lot of the underlying
 // functionality is provided by the Syncable layer, which has its own
 // unit tests. We'll test SyncApi specific things in this harness.
 
 #include <cstddef>
 #include <map>
@@ skipping 2878 matching lines @@
   // non-fatal failure if these changes are not found.
   size_t folder_change_pos =
       FindChangeInList(folder_id, ChangeRecord::ACTION_ADD);
   size_t child_change_pos =
       FindChangeInList(child_id, ChangeRecord::ACTION_ADD);
 
   // Parents are delivered before children.
   EXPECT_LT(folder_change_pos, child_change_pos);
 }
 
+// Test creation of a preferences (with implicit parent Id)
+TEST_F(SyncManagerChangeProcessingTest, AddPreferences) {
+  int64 item1_id = kInvalidId;
+  int64 item2_id = kInvalidId;
+
+  // Create two preferences.
+  {
+    syncable::WriteTransaction trans(FROM_HERE, syncable::SYNCER,
+                                     share()->directory.get());
+
+    syncable::MutableEntry item1(&trans, syncable::CREATE, PREFERENCES,
+                                 "test_item_1");
+    ASSERT_TRUE(item1.good());
+    SetNodeProperties(&item1);
+    item1_id = item1.GetMetahandle();
+
+    // Need at least two items to ensure hitting all possible codepaths in
+    // ChangeReorderBuffer::Traversal::ExpandToInclude.
+    syncable::MutableEntry item2(&trans, syncable::CREATE, PREFERENCES,
+                                 "test_item_2");
+    ASSERT_TRUE(item2.good());
+    SetNodeProperties(&item2);
+    item2_id = item2.GetMetahandle();
+  }
+
+  // The closing of the above scope will delete the transaction.  Its processed
+  // changes should be waiting for us in a member of the test harness.
+  EXPECT_EQ(2UL, GetChangeListSize());
+
+  FindChangeInList(item1_id, ChangeRecord::ACTION_ADD);
+  FindChangeInList(item2_id, ChangeRecord::ACTION_ADD);
+}
+
 // Test moving a bookmark into an empty folder.
 TEST_F(SyncManagerChangeProcessingTest, MoveBookmarkIntoEmptyFolder) {
   int64 type_root = GetIdForDataType(BOOKMARKS);
   int64 folder_b_id = kInvalidId;
   int64 child_id = kInvalidId;
 
   // Create two folders.  Place a child under folder A.
   {
     syncable::WriteTransaction trans(
         FROM_HERE, syncable::SYNCER, share()->directory.get());
@@ skipping 255 matching lines @@
 // SyncManagerInitInvalidStorageTest::GetFactory will return
 // DirectoryBackingStore that ensures that SyncManagerImpl::OpenDirectory fails.
 // SyncManagerImpl initialization is done in SyncManagerTest::SetUp. This test's
 // task is to ensure that SyncManagerImpl reported initialization failure in
 // OnInitializationComplete callback.
 TEST_F(SyncManagerInitInvalidStorageTest, FailToOpenDatabase) {
   EXPECT_FALSE(initialization_succeeded_);
 }
 
 }  // namespace syncer