Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1456)

Unified Diff: minidump/minidump_thread_writer_test.cc

Issue 992693003: Add ASSERT_DEATH_CHECK() to do ASSERT_DEATH() of CHECK() failures (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_system_info_writer_test.cc ('k') | util/mach/composite_mach_message_server_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_thread_writer_test.cc
diff --git a/minidump/minidump_thread_writer_test.cc b/minidump/minidump_thread_writer_test.cc
index 291f70a3957c98327afa589bbaa58b37c27f4e49..94ec200a1f68dd38c121f0e8cacfbe4158b94a8c 100644
--- a/minidump/minidump_thread_writer_test.cc
+++ b/minidump/minidump_thread_writer_test.cc
@@ -34,6 +34,7 @@
#include "snapshot/test/test_memory_snapshot.h"
#include "snapshot/test/test_thread_snapshot.h"
#include "util/file/string_file.h"
+#include "util/test/gtest_death_check.h"
namespace crashpad {
namespace test {
@@ -674,11 +675,12 @@ TEST(MinidumpThreadWriterDeathTest, NoContext) {
minidump_file_writer.AddStream(thread_list_writer.Pass());
StringFile string_file;
- ASSERT_DEATH(minidump_file_writer.WriteEverything(&string_file), "context_");
+ ASSERT_DEATH_CHECK(minidump_file_writer.WriteEverything(&string_file),
+ "context_");
}
TEST(MinidumpThreadWriterDeathTest, InitializeFromSnapshot_NoContext) {
- ASSERT_DEATH(
+ ASSERT_DEATH_CHECK(
RunInitializeFromSnapshotTest<InitializeFromSnapshotNoContextTraits>(
false), "context_");
}
« no previous file with comments | « minidump/minidump_system_info_writer_test.cc ('k') | util/mach/composite_mach_message_server_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698