Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 992603002: Oilpan: avoid ODR warning when linking heap unit tests. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: avoid ODR warning when linking heap unit tests. Do not replace blink::Node in unit tests and risk triggering linker ODR warnings, but instead define a uniquely named test object and assign it to the Node typed heap. R=haraken BUG=420515, 449754 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M Source/platform/heap/HeapTest.cpp View 4 chunks +21 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look.
5 years, 9 months ago (2015-03-09 07:35:55 UTC) #2
haraken
LGTM I had the same error and was wondering why :)
5 years, 9 months ago (2015-03-09 07:37:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992603002/1
5 years, 9 months ago (2015-03-09 07:40:56 UTC) #5
sof
On 2015/03/09 07:37:16, haraken wrote: > LGTM > > I had the same error and ...
5 years, 9 months ago (2015-03-09 07:49:41 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 09:05:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191530

Powered by Google App Engine
This is Rietveld 408576698