[Android WebView] Lay the groundwork for a better onReceivedError

[Android WebView] Lay the groundwork for a better onReceivedError

This patch should not change any behaviour. It introduces a new version
of onReceviedError that will be called for all resources and provides
more information about the failed request.

BUG=456782
Committed: https://crrev.com/f0a8ffb2ca988fe7de628620f750ee241e5f5d35
Cr-Commit-Position: refs/heads/master@{#319664}

[mnaganov (inactive), 2015-03-09 12:57:34]

mnaganov@chromium.org changed reviewers:
+ torne@chromium.org

[Torne, 2015-03-09 16:00:36]

LGTM with one comment

https://codereview.chromium.org/992593003/diff/40001/android_webview/glue/jav...
File
android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
(right):

https://codereview.chromium.org/992593003/diff/40001/android_webview/glue/jav...
android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java:614:
error.description = mWebViewDelegate.getErrorString(mContext, error.errorCode);
Is this costly at all? We might want to only do it if we're on the right API
level since for now this whole callback is going nowhere.

[mnaganov (inactive), 2015-03-09 16:53:40]

https://codereview.chromium.org/992593003/diff/40001/android_webview/glue/jav...
File
android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
(right):

https://codereview.chromium.org/992593003/diff/40001/android_webview/glue/jav...
android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java:614:
error.description = mWebViewDelegate.getErrorString(mContext, error.errorCode);
On 2015/03/09 16:00:36, Torne wrote:
> Is this costly at all? We might want to only do it if we're on the right API
> level since for now this whole callback is going nowhere.

It goes into some reflection bullsh*t, so indeed let's avoid it. Actually, in
the meantime, I was thinking that since it is always only one of these two
methods that takes action, there are no reasons for not doing an early fallback
depending on the API level at the very beginning of both methods.

[mnaganov (inactive), 2015-03-09 16:54:49]

The CQ bit was checked by mnaganov@chromium.org

[mnaganov (inactive), 2015-03-09 16:54:50]

The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org
Link to the patchset: https://codereview.chromium.org/992593003/#ps60001 (title:
"Comments addressed")

[commit-bot: I haz the power, 2015-03-09 16:55:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/992593003/60001

[commit-bot: I haz the power, 2015-03-09 17:18:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-09 17:19:19]

Patchset 4 (id:??) landed as
https://crrev.com/f0a8ffb2ca988fe7de628620f750ee241e5f5d35
Cr-Commit-Position: refs/heads/master@{#319664}