android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientCallbackHelperTest.java - Issue 992593003: [Android WebView] Lay the groundwork for a better onReceivedError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientCallbackHelperTest.java

Issue 992593003: [Android WebView] Lay the groundwork for a better onReceivedError (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments addressed Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java ('k') | android_webview/test/shell/src/org/chromium/android_webview/test/NullContentsClient.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientCallbackHelperTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientCallbackHelperTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientCallbackHelperTest.java

index 7fa242e1567f1f96b0642204aa2a3a61b5437a09..de9eb401c9ba86b310d51f6291883c5b0a3e52a3 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientCallbackHelperTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientCallbackHelperTest.java

@@ -10,6 +10,7 @@ import android.os.Handler;

import android.os.Looper;

import android.test.suitebuilder.annotation.SmallTest;

+import org.chromium.android_webview.AwContentsClient;

import org.chromium.android_webview.AwContentsClientCallbackHelper;

import org.chromium.android_webview.test.TestAwContentsClient.OnDownloadStartHelper;

import org.chromium.android_webview.test.TestAwContentsClient.OnReceivedLoginRequestHelper;

@@ -203,7 +204,13 @@ public class AwContentsClientCallbackHelperTest extends AwTestBase {

mContentsClient.getOnReceivedErrorHelper();

int onReceivedErrorCount = receivedErrorHelper.getCallCount();

- mClientHelper.postOnReceivedError(ERROR_CODE, ERROR_MESSAGE, TEST_URL);

+ AwContentsClient.AwWebResourceRequest request = new AwContentsClient.AwWebResourceRequest();

+ request.url = TEST_URL;

+ request.isMainFrame = true;

+ AwContentsClient.AwWebResourceError error = new AwContentsClient.AwWebResourceError();

+ error.errorCode = ERROR_CODE;

+ error.description = ERROR_MESSAGE;

+ mClientHelper.postOnReceivedError(request, error);

receivedErrorHelper.waitForCallback(onReceivedErrorCount);

assertEquals(ERROR_CODE, receivedErrorHelper.getErrorCode());

assertEquals(ERROR_MESSAGE, receivedErrorHelper.getDescription());