Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 99243002: Experimental scanner multithreading fix. (Closed)

Created:
7 years ago by marja
Modified:
7 years ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Experimental scanner multithreading fix. Many ExperimentalScanners might get created simultaneously in different threads, so we cannot just keep track of them without locking. Moving the bookkeeping into Isolate. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18199

Patch Set 1 #

Total comments: 1

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -37 lines) Patch
M src/isolate.h View 5 chunks +13 lines, -0 lines 0 comments Download
M src/isolate.cc View 3 chunks +34 lines, -0 lines 0 comments Download
M src/lexer/experimental-scanner.h View 8 chunks +11 lines, -26 lines 0 comments Download
M src/lexer/experimental-scanner.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ulan
LGTM https://codereview.chromium.org/99243002/diff/1/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/99243002/diff/1/src/isolate.cc#newcode2543 src/isolate.cc:2543: heap()->AddGCEpilogueCallback( Not sure. It is probably better do ...
7 years ago (2013-12-02 15:05:42 UTC) #1
marja
7 years ago (2013-12-02 15:07:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r18199 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698