Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 99233002: Remove TreatNullAs=NullString for HTMLObjectElement (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
CC:
blink-reviews, adamk+blink_chromium.org, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Remove TreatNullAs=NullString for HTMLObjectElement http://whatwg.org/html#htmlobjectelement http://whatwg.org/html#HTMLObjectElement-partial Make the codebase attribute reflect as a URL, as per spec. The border attribute has [TreatNullAs=EmptyString] in the spec. The tests for the updated properties pass in Firefox Nightly, IE11 Release Preview and Opera 12.16, with these exceptions: Firefox reflect code as a URL. IE throws an exception for align, doesn't reflect codeBase as a URL, and reflects width/height as the empty string. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163037

Patch Set 1 #

Patch Set 2 : make codebase a URL attribute #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -41 lines) Patch
M LayoutTests/fast/dom/domstring-attribute-reflection.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/domstring-attribute-reflection-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null.html View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.idl View 1 2 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
7 years ago (2013-12-02 15:31:51 UTC) #1
arv (Not doing code reviews)
LGTM
7 years ago (2013-12-02 15:38:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/99233002/20001
7 years ago (2013-12-02 15:39:36 UTC) #3
commit-bot: I haz the power
Failed to apply patch for LayoutTests/fast/dom/domstring-attribute-reflection.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-02 16:48:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/99233002/40001
7 years ago (2013-12-02 21:36:12 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-02 22:51:59 UTC) #6
Message was sent while issue was closed.
Change committed as 163037

Powered by Google App Engine
This is Rietveld 408576698