Source/core/html/HTMLObjectElement.cpp - Issue 99233002: Remove TreatNullAs=NullString for HTMLObjectElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLObjectElement.cpp

Issue 99233002: Remove TreatNullAs=NullString for HTMLObjectElement (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLObjectElement.cpp

diff --git a/Source/core/html/HTMLObjectElement.cpp b/Source/core/html/HTMLObjectElement.cpp

index e6f66a85f54d830dfe1570869cbf558b2cd01d3e..de819463af26de2bd1d94c6eacd595814d05b8aa 100644

--- a/Source/core/html/HTMLObjectElement.cpp

+++ b/Source/core/html/HTMLObjectElement.cpp

@@ -344,7 +344,9 @@ void HTMLObjectElement::childrenChanged(bool changedByParser, Node* beforeChange

bool HTMLObjectElement::isURLAttribute(const Attribute& attribute) const

{

- return attribute.name() == dataAttr || (attribute.name() == usemapAttr && attribute.value().string()[0] != '#') || HTMLPlugInElement::isURLAttribute(attribute);

+ return attribute.name() == codebaseAttr || attribute.name() == dataAttr

+ || (attribute.name() == usemapAttr && attribute.value().string()[0] != '#')

+ || HTMLPlugInElement::isURLAttribute(attribute);

}

const AtomicString HTMLObjectElement::imageSourceURL() const

« no previous file with comments | « LayoutTests/fast/dom/element-attribute-js-null-expected.txt ('k') | Source/core/html/HTMLObjectElement.idl » ('j') | no next file with comments »