Fixed current OOBE captive portal metrics.

Fixed current OOBE captive portal metrics.

Now metrics are recorded only when a state of a particular network is
changed. If several consecutive checks indicate the same state for a
network, only the first one is recorded. The purpose of this fix is to
remove noize from so-called "lazy detection" from metrics.

BUG=231758
TEST=unit_tests:NetworkPortalDetectorImplTest*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243945

[Nikita (slow), 2014-01-09 13:48:56]

lgtm with nits

Do you need to update histogram descriptions?

https://codereview.chromium.org/99223009/diff/80001/chrome/browser/chromeos/n...
File chrome/browser/chromeos/net/network_portal_detector_impl.cc (right):

https://codereview.chromium.org/99223009/diff/80001/chrome/browser/chromeos/n...
chrome/browser/chromeos/net/network_portal_detector_impl.cc:468: // interested
only on distribution of detection duration, not
nit: update comment, all stats are reported only once per state changed.

https://codereview.chromium.org/99223009/diff/80001/chrome/browser/chromeos/n...
chrome/browser/chromeos/net/network_portal_detector_impl.cc:517:
UMA_HISTOGRAM_ENUMERATION("CaptivePortal.OOBE.DetectionResult", status,
nit: status on a separate line.

https://codereview.chromium.org/99223009/diff/80001/chrome/browser/chromeos/n...
chrome/browser/chromeos/net/network_portal_detector_impl.cc:526:
RecordDiscrepancyWithShill(network, status);
nit: {}

https://codereview.chromium.org/99223009/diff/80001/chrome/browser/chromeos/n...
File chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc
(right):

https://codereview.chromium.org/99223009/diff/80001/chrome/browser/chromeos/n...
chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc:45: const
char kResultHistogram[] = "CaptivePortal.OOBE.DetectionResult";
nit: Please move this histogram name to header.

https://codereview.chromium.org/99223009/diff/80001/chrome/browser/chromeos/n...
chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc:61: class
ResultHistogramChecker {
nit: I wonder how histogram reporting is checked on metrics_service tests? Is
there a similar helper class?

[ygorshenin1, 2014-01-09 14:59:35]

Many thanks!

https://codereview.chromium.org/99223009/diff/80001/chrome/browser/chromeos/n...
File chrome/browser/chromeos/net/network_portal_detector_impl.cc (right):

https://codereview.chromium.org/99223009/diff/80001/chrome/browser/chromeos/n...
chrome/browser/chromeos/net/network_portal_detector_impl.cc:468: // interested
only on distribution of detection duration, not
On 2014/01/09 13:48:56, Nikita Kostylev wrote:
> nit: update comment, all stats are reported only once per state changed.

Done.

https://codereview.chromium.org/99223009/diff/80001/chrome/browser/chromeos/n...
chrome/browser/chromeos/net/network_portal_detector_impl.cc:517:
UMA_HISTOGRAM_ENUMERATION("CaptivePortal.OOBE.DetectionResult", status,
On 2014/01/09 13:48:56, Nikita Kostylev wrote:
> nit: status on a separate line.

Done.

https://codereview.chromium.org/99223009/diff/80001/chrome/browser/chromeos/n...
chrome/browser/chromeos/net/network_portal_detector_impl.cc:526:
RecordDiscrepancyWithShill(network, status);
On 2014/01/09 13:48:56, Nikita Kostylev wrote:
> nit: {}

Done.

https://codereview.chromium.org/99223009/diff/80001/chrome/browser/chromeos/n...
File chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc
(right):

https://codereview.chromium.org/99223009/diff/80001/chrome/browser/chromeos/n...
chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc:45: const
char kResultHistogram[] = "CaptivePortal.OOBE.DetectionResult";
On 2014/01/09 13:48:56, Nikita Kostylev wrote:
> nit: Please move this histogram name to header.

Done.

[commit-bot: I haz the power, 2014-01-09 15:00:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/99223009/120001

[commit-bot: I haz the power, 2014-01-09 19:04:31]

Change committed as 243945